From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zoltan Kiss Subject: Re: [PATCH v4] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors Date: Wed, 26 Mar 2014 22:38:48 +0000 Message-ID: <533356F8.7070307@citrix.com> References: <1395397894-9493-1-git-send-email-zoltan.kiss@citrix.com> <20140326.155958.1928261590856069753.davem@davemloft.net> <20140326.161242.576245997077162750.davem@davemloft.net> Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20140326.161242.576245997077162750.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Sender: "dev" Content-Type: text/plain; charset="iso-8859-1"; format="flowed" To: David Miller Cc: netfilter-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mszeredi-AlSwsSmVLrQ@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, JBeulich-IBi9RG/b67k@public.gmane.org, therbert-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org, kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO@public.gmane.org, xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org, jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org, Paul.Durrant-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org T24gMjYvMDMvMTQgMjA6MTIsIERhdmlkIE1pbGxlciB3cm90ZToKPiBGcm9tOiBEYXZpZCBNaWxs ZXIgPGRhdmVtQGRhdmVtbG9mdC5uZXQ+Cj4gRGF0ZTogV2VkLCAyNiBNYXIgMjAxNCAxNTo1OTo1 OCAtMDQwMCAoRURUKQo+Cj4+IEZyb206IFpvbHRhbiBLaXNzIDx6b2x0YW4ua2lzc0BjaXRyaXgu Y29tPgo+PiBEYXRlOiBGcmksIDIxIE1hciAyMDE0IDEwOjMxOjM0ICswMDAwCj4+Cj4+PiBza2Jf emVyb2NvcHkgY2FuIGNvcHkgZWxlbWVudHMgb2YgdGhlIGZyYWdzIGFycmF5IGJldHdlZW4gc2ti cywgYnV0IGl0IGRvZXNuJ3QKPj4+IG9ycGhhbiB0aGVtLiBBbHNvLCBpdCBkb2Vzbid0IGhhbmRs ZSBlcnJvcnMsIHNvIHRoaXMgcGF0Y2ggdGFrZXMgY2FyZSBvZiB0aGF0Cj4+PiBhcyB3ZWxsLCBh bmQgbW9kaWZ5IHRoZSBjYWxsZXJzIGFjY29yZGluZ2x5LiBza2JfdHhfZXJyb3IoKSBpcyBhbHNv IGFkZGVkIHRvCj4+PiB0aGUgY2FsbGVycyBzbyB0aGV5IHdpbGwgc2lnbmFsIHRoZSBmYWlsZWQg ZGVsaXZlcnkgdG93YXJkcyB0aGUgY3JlYXRvciBvZiB0aGUKPj4+IHNrYi4KPj4+Cj4+PiBTaWdu ZWQtb2ZmLWJ5OiBab2x0YW4gS2lzcyA8em9sdGFuLmtpc3NAY2l0cml4LmNvbT4KPj4KPj4gQXBw bGllZCwgdGhhbmtzIFpvbHRhbi4KPgo+IEFjdHVhbGx5LCBab2x0YW4sIHlvdSBoYXZlIHRvIGZp eCB0aGlzOgo+Cj4gbmV0L2NvcmUvc2tidWZmLmM6IEluIGZ1bmN0aW9uIKFza2JfemVyb2NvcHmi Ogo+IG5ldC9jb3JlL3NrYnVmZi5jOjIxNzI6Mjogd2FybmluZzogcGFzc2luZyBhcmd1bWVudCAx IG9mIKFza2Jfb3JwaGFuX2ZyYWdzoiBkaXNjYXJkcyChY29uc3SiIHF1YWxpZmkKPiBlciBmcm9t IHBvaW50ZXIgdGFyZ2V0IHR5cGUgW2VuYWJsZWQgYnkgZGVmYXVsdF0KPiBJbiBmaWxlIGluY2x1 ZGVkIGZyb20gaW5jbHVkZS9saW51eC90Y3AuaDoyMTowLAo+ICAgICAgICAgICAgICAgICAgIGZy b20gbmV0L2NvcmUvc2tidWZmLmM6NTA6Cj4gaW5jbHVkZS9saW51eC9za2J1ZmYuaDoxOTA0OjE5 OiBub3RlOiBleHBlY3RlZCChc3RydWN0IHNrX2J1ZmYgKqIgYnV0IGFyZ3VtZW50IGlzIG9mIHR5 cGUgoWNvbnN0IHN0cgo+IHVjdCBza19idWZmICqiCj4gbmV0L2NvcmUvc2tidWZmLmM6MjE3Mzoz OiB3YXJuaW5nOiBwYXNzaW5nIGFyZ3VtZW50IDEgb2YgoXNrYl90eF9lcnJvcqIgZGlzY2FyZHMg oWNvbnN0oiBxdWFsaWZpZXIgZgo+IHJvbSBwb2ludGVyIHRhcmdldCB0eXBlIFtlbmFibGVkIGJ5 IGRlZmF1bHRdCj4gbmV0L2NvcmUvc2tidWZmLmM6NjQyOjY6IG5vdGU6IGV4cGVjdGVkIKFzdHJ1 Y3Qgc2tfYnVmZiAqoiBidXQgYXJndW1lbnQgaXMgb2YgdHlwZSChY29uc3Qgc3RydWN0IHNrXwo+ IGJ1ZmYgKqIKPgoKT2ssIHJlc3VibWl0dGVkLiAnZnJvbScgaXMgbm93IG5vdCBhIGNvbnN0IHBh cmFtZXRlciwgYmVjYXVzZSAKc2tiLT5wZm1lbWFsbG9jIG1pZ2h0IGNoYW5nZS4KClpvbGkKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2IG1haWxpbmcg bGlzdApkZXZAb3BlbnZzd2l0Y2gub3JnCmh0dHA6Ly9vcGVudnN3aXRjaC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kZXYK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zoltan Kiss Subject: Re: [PATCH v4] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors Date: Wed, 26 Mar 2014 22:38:48 +0000 Message-ID: <533356F8.7070307@citrix.com> References: <1395397894-9493-1-git-send-email-zoltan.kiss@citrix.com> <20140326.155958.1928261590856069753.davem@davemloft.net> <20140326.161242.576245997077162750.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso8859-7"; Format="flowed" Content-Transfer-Encoding: base64 Cc: netfilter-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mszeredi-AlSwsSmVLrQ@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, JBeulich-IBi9RG/b67k@public.gmane.org, therbert-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org, kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO@public.gmane.org, xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org, jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org, Paul.Durrant-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org To: David Miller Return-path: In-Reply-To: <20140326.161242.576245997077162750.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Sender: "dev" List-Id: netfilter-devel.vger.kernel.org T24gMjYvMDMvMTQgMjA6MTIsIERhdmlkIE1pbGxlciB3cm90ZToKPiBGcm9tOiBEYXZpZCBNaWxs ZXIgPGRhdmVtQGRhdmVtbG9mdC5uZXQ+Cj4gRGF0ZTogV2VkLCAyNiBNYXIgMjAxNCAxNTo1OTo1 OCAtMDQwMCAoRURUKQo+Cj4+IEZyb206IFpvbHRhbiBLaXNzIDx6b2x0YW4ua2lzc0BjaXRyaXgu Y29tPgo+PiBEYXRlOiBGcmksIDIxIE1hciAyMDE0IDEwOjMxOjM0ICswMDAwCj4+Cj4+PiBza2Jf emVyb2NvcHkgY2FuIGNvcHkgZWxlbWVudHMgb2YgdGhlIGZyYWdzIGFycmF5IGJldHdlZW4gc2ti cywgYnV0IGl0IGRvZXNuJ3QKPj4+IG9ycGhhbiB0aGVtLiBBbHNvLCBpdCBkb2Vzbid0IGhhbmRs ZSBlcnJvcnMsIHNvIHRoaXMgcGF0Y2ggdGFrZXMgY2FyZSBvZiB0aGF0Cj4+PiBhcyB3ZWxsLCBh bmQgbW9kaWZ5IHRoZSBjYWxsZXJzIGFjY29yZGluZ2x5LiBza2JfdHhfZXJyb3IoKSBpcyBhbHNv IGFkZGVkIHRvCj4+PiB0aGUgY2FsbGVycyBzbyB0aGV5IHdpbGwgc2lnbmFsIHRoZSBmYWlsZWQg ZGVsaXZlcnkgdG93YXJkcyB0aGUgY3JlYXRvciBvZiB0aGUKPj4+IHNrYi4KPj4+Cj4+PiBTaWdu ZWQtb2ZmLWJ5OiBab2x0YW4gS2lzcyA8em9sdGFuLmtpc3NAY2l0cml4LmNvbT4KPj4KPj4gQXBw bGllZCwgdGhhbmtzIFpvbHRhbi4KPgo+IEFjdHVhbGx5LCBab2x0YW4sIHlvdSBoYXZlIHRvIGZp eCB0aGlzOgo+Cj4gbmV0L2NvcmUvc2tidWZmLmM6IEluIGZ1bmN0aW9uIKFza2JfemVyb2NvcHmi Ogo+IG5ldC9jb3JlL3NrYnVmZi5jOjIxNzI6Mjogd2FybmluZzogcGFzc2luZyBhcmd1bWVudCAx IG9mIKFza2Jfb3JwaGFuX2ZyYWdzoiBkaXNjYXJkcyChY29uc3SiIHF1YWxpZmkKPiBlciBmcm9t IHBvaW50ZXIgdGFyZ2V0IHR5cGUgW2VuYWJsZWQgYnkgZGVmYXVsdF0KPiBJbiBmaWxlIGluY2x1 ZGVkIGZyb20gaW5jbHVkZS9saW51eC90Y3AuaDoyMTowLAo+ICAgICAgICAgICAgICAgICAgIGZy b20gbmV0L2NvcmUvc2tidWZmLmM6NTA6Cj4gaW5jbHVkZS9saW51eC9za2J1ZmYuaDoxOTA0OjE5 OiBub3RlOiBleHBlY3RlZCChc3RydWN0IHNrX2J1ZmYgKqIgYnV0IGFyZ3VtZW50IGlzIG9mIHR5 cGUgoWNvbnN0IHN0cgo+IHVjdCBza19idWZmICqiCj4gbmV0L2NvcmUvc2tidWZmLmM6MjE3Mzoz OiB3YXJuaW5nOiBwYXNzaW5nIGFyZ3VtZW50IDEgb2YgoXNrYl90eF9lcnJvcqIgZGlzY2FyZHMg oWNvbnN0oiBxdWFsaWZpZXIgZgo+IHJvbSBwb2ludGVyIHRhcmdldCB0eXBlIFtlbmFibGVkIGJ5 IGRlZmF1bHRdCj4gbmV0L2NvcmUvc2tidWZmLmM6NjQyOjY6IG5vdGU6IGV4cGVjdGVkIKFzdHJ1 Y3Qgc2tfYnVmZiAqoiBidXQgYXJndW1lbnQgaXMgb2YgdHlwZSChY29uc3Qgc3RydWN0IHNrXwo+ IGJ1ZmYgKqIKPgoKT2ssIHJlc3VibWl0dGVkLiAnZnJvbScgaXMgbm93IG5vdCBhIGNvbnN0IHBh cmFtZXRlciwgYmVjYXVzZSAKc2tiLT5wZm1lbWFsbG9jIG1pZ2h0IGNoYW5nZS4KClpvbGkKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2IG1haWxpbmcg bGlzdApkZXZAb3BlbnZzd2l0Y2gub3JnCmh0dHA6Ly9vcGVudnN3aXRjaC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kZXYK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756695AbaCZWi6 (ORCPT ); Wed, 26 Mar 2014 18:38:58 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:15059 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756353AbaCZWix (ORCPT ); Wed, 26 Mar 2014 18:38:53 -0400 X-IronPort-AV: E=Sophos;i="4.97,738,1389744000"; d="scan'208";a="113959114" Message-ID: <533356F8.7070307@citrix.com> Date: Wed, 26 Mar 2014 22:38:48 +0000 From: Zoltan Kiss User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: David Miller CC: , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors References: <1395397894-9493-1-git-send-email-zoltan.kiss@citrix.com> <20140326.155958.1928261590856069753.davem@davemloft.net> <20140326.161242.576245997077162750.davem@davemloft.net> In-Reply-To: <20140326.161242.576245997077162750.davem@davemloft.net> Content-Type: text/plain; charset="ISO-8859-7"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.2.133] X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/03/14 20:12, David Miller wrote: > From: David Miller > Date: Wed, 26 Mar 2014 15:59:58 -0400 (EDT) > >> From: Zoltan Kiss >> Date: Fri, 21 Mar 2014 10:31:34 +0000 >> >>> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't >>> orphan them. Also, it doesn't handle errors, so this patch takes care of that >>> as well, and modify the callers accordingly. skb_tx_error() is also added to >>> the callers so they will signal the failed delivery towards the creator of the >>> skb. >>> >>> Signed-off-by: Zoltan Kiss >> >> Applied, thanks Zoltan. > > Actually, Zoltan, you have to fix this: > > net/core/skbuff.c: In function ¡skb_zerocopy¢: > net/core/skbuff.c:2172:2: warning: passing argument 1 of ¡skb_orphan_frags¢ discards ¡const¢ qualifi > er from pointer target type [enabled by default] > In file included from include/linux/tcp.h:21:0, > from net/core/skbuff.c:50: > include/linux/skbuff.h:1904:19: note: expected ¡struct sk_buff *¢ but argument is of type ¡const str > uct sk_buff *¢ > net/core/skbuff.c:2173:3: warning: passing argument 1 of ¡skb_tx_error¢ discards ¡const¢ qualifier f > rom pointer target type [enabled by default] > net/core/skbuff.c:642:6: note: expected ¡struct sk_buff *¢ but argument is of type ¡const struct sk_ > buff *¢ > Ok, resubmitted. 'from' is now not a const parameter, because skb->pfmemalloc might change. Zoli