From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Haigh Subject: Re: Possible memory leak in qemu-dm (qemu-dm swapping 20GB+, adding 2gb+ per day) Date: Thu, 27 Mar 2014 10:49:49 +1100 Message-ID: <5333679D.2010407@crc.id.au> References: <5330E500.6020906@crc.id.au> <20140325070913.GC3200@reaktio.net> <1395743334.6294.37.camel@kazak.uk.xensource.com> <53315EE5.7050803@crc.id.au> <1395745431.6294.46.camel@kazak.uk.xensource.com> <533165A3.20605@citrix.com> <5332646C.4040905@crc.id.au> <1395824223.29683.20.camel@dagon.hellion.org.uk> <5332994A.5080203@crc.id.au> <1395826894.22808.15.camel@kazak.uk.xensource.com> <20140326150159.GF3200@reaktio.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1222262295241360529==" Return-path: In-Reply-To: <20140326150159.GF3200@reaktio.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: =?ISO-8859-1?Q?Pasi_K=E4rkk=E4inen?= , Ian Campbell Cc: Andrew Cooper , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1222262295241360529== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tK0iUrhPEmCgpDB7mSPibnFAGkeJ7diAO" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tK0iUrhPEmCgpDB7mSPibnFAGkeJ7diAO Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 27/03/14 02:01, Pasi K=E4rkk=E4inen wrote: > On Wed, Mar 26, 2014 at 09:41:34AM +0000, Ian Campbell wrote: >> On Wed, 2014-03-26 at 20:09 +1100, Steven Haigh wrote: >>> On 26/03/14 19:57, Ian Campbell wrote: >>>> On Wed, 2014-03-26 at 16:23 +1100, Steven Haigh wrote: >>>>> Valgrind log available here: >>>>> http://xen.crc.id.au/bugs/view.php?id=3D25 >>>> >>>> Thanks. >>>> >>>> Before we go any further, can you confirm that you have this commit = in >>>> your qemu-xen-traditional tree: >>>> commit 96b58a44756a8821c108358439b0f2c06e531159 >>>> Author: Matthew Daley >>>> Date: Wed Dec 4 15:16:18 2013 +1300 >>>> =20 >>>> xen_disk: fix memory leak >>>> =20 >>>> On ioreq_release the full ioreq was memset to 0, losing = all the data >>>> and memory allocations inside the QEMUIOVector, which le= ads to a >>>> memory leak. Create a new function to specifically reset= ioreq. >>>> =20 >>>> Reported-by: Maik Wessler >>>> Signed-off-by: Roger Pau Monn=E9 >>>> Signed-off-by: Stefano Stabellini >>>> =20 >>>> Backport to qemu-xen-traditional. >>>> =20 >>>> Signed-off-by: Matthew Daley >>>> Acked-by: Ian Jackson >>>> =20 >>>>> Do you have any further suggestions / ideas based on this? >>>> >>>> Unfortunately the qemu-dm binary seems to have been stripped, which >>>> removes much of the useful info from the traces. Please can you make= >>>> sure you have the following commit to the qemu-xen-traditional tree:= >>>> commit 18a08a23da88863435d56a0b14ff72013ef3b003 >>>> Author: Olaf Hering >>>> Date: Tue Oct 15 11:42:26 2013 +0200 >>>> =20 >>>> qemu-traditional: do not strip binaries during make inst= all >>>> =20 >>>> It is wrong to strip code during make install, unless ex= plicit >>>> requested. Introduce a new variable INSTALL_PROG and use= it along with >>>> an optional STRIP_OPT where currently install -s -m 755 = is used. >>>> This is what upstream qemu offers in version 1.6. >>>> =20 >>>> Signed-off-by: Olaf Hering >>>> =20 >>> >>> I am using the qemu-xen-traditional that comes with xen-4.2.3.tar.gz >> >> And have you confirmed that this does or does not contain the above fi= x? >> >=20 > http://xenbits.xen.org/gitweb/?p=3Dqemu-xen-4.2-testing.git;a=3Dsummary= >=20 > So qemu-traditional in Xen 4.2.3 does NOT have the fix. > The fix is included in Xen 4.2.4. Thanks - I think I missed the release announcement of 4.2.4. Ian clued me onto this yesterday. I've rebuilt the packages based on 4.2.4 and am awaiting confirmation that this does fix the error. -- Steven Haigh Email: netwiz@crc.id.au Web: http://www.crc.id.au Phone: (03) 9001 6090 - 0412 935 897 Fax: (03) 8338 0299 --tK0iUrhPEmCgpDB7mSPibnFAGkeJ7diAO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTM2ehAAoJEEGvNdV6fTHcfkkP/j9v1obtyPriXKCFBE6tVqqX 5Nx6FFan+/VlvT49cbq28e9M0VW8KC9gk4wOv/0LJvs9iYB2r+eGWamlexxk4vct 6fTa9on6LGXQ8cXcr7NJg/SAHWUnBbXvj1Gyb44O/bvkjXcO4A6DD9zEJ6aeq8Pf nSa/puK0uXdIuga1nfHE1OykWUamqUukaG9IEUuZVx6xU7GCWYk9Yyb8GFOvP6fJ slW2sGDiajVE3HuYsZRSV17pwD6iGf0qaU6vRjy5GFxCSSao8gt56ZTgpIvWJaV7 TGzlJTszUDWsFbA/2IT6sWBRBPNzq5npdnkTZUkUaOvGkdO82ErdVrT4XJmHVI8o BukPyj9HozyMSbnCTYzkMidRchDhtGw5y6eyzJfFoxxFxlelo6Su4FMIdQuXHWQi CEKxxdeREdmvjOXyYmeBya84v3q9AAmptpxhu4bVEWCM20zkbwluUMm2Yig/p6WV VVCICO0HUTCFleRo2Yn5yeKyUYLiTIlLpRB9NdUi83PV1NC898Ck8dIWlRqQ/4h6 Nzi2PFjdpZ0PqqwegSi6iV+X753yOKk9bq7hqeDG/85Byy8sHV1LS8feIvQ7JrHY itlUwgVhKYvQVfG836XMPa4lzVxEUmtAIaShD5UUFvXm/O8tB/TLmpRemgkigwPr cPyWWa3FM0fGUD54DW2G =Muyz -----END PGP SIGNATURE----- --tK0iUrhPEmCgpDB7mSPibnFAGkeJ7diAO-- --===============1222262295241360529== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1222262295241360529==--