From: Peter Hurley <peter@hurleysoftware.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Felipe Balbi <balbi@ti.com>, Greg KH <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-bluetooth@vger.kernel.org,
m-karicheri2@ti.com, b32955@freescale.com,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 10/11] Revert "serial: omap: unlock the port lock"
Date: Wed, 26 Mar 2014 20:39:11 -0400 [thread overview]
Message-ID: <5333732F.6040803@hurleysoftware.com> (raw)
In-Reply-To: <20140325182856.GA31906@atomide.com>
On 03/25/2014 02:28 PM, Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [140320 12:39]:
>> This reverts commit 0324a821029e1f54e7a7f8fed48693cfce42dc0e.
>>
>> That commit tried to fix a deadlock problem when using
>> hci_ldisc, but it turns out the bug was in hci_ldsic
>> all along where it was calling ->write() from within
>> ->write_wakeup() callback.
>>
>> The problem is that ->write_wakeup() was called with
>> port lock held and ->write() tried to grab the same
>> port lock.
>
> Should this and the next patch be earlier in the series
> as a fix for the v3.15-rc cycle? Should they be cc: stable
> as well?
Well, right now the other fix has had _zero_ testing
so not really a -stable candidate just yet.
next prev parent reply other threads:[~2014-03-27 0:39 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 19:29 [PATCH 01/11] tty: serial: add missing braces Felipe Balbi
2014-03-20 19:29 ` Felipe Balbi
2014-03-20 19:29 ` [PATCH 02/11] tty: serial: omap: switch over to devm_request_gpio Felipe Balbi
2014-03-20 19:29 ` Felipe Balbi
2014-03-20 19:29 ` [PATCH 03/11] tty: serial: omap: cleanup variable declarations Felipe Balbi
2014-03-20 19:29 ` Felipe Balbi
2014-03-20 19:30 ` [PATCH 04/11] tty: serial: omap: switch over to platform_get_resource Felipe Balbi
2014-03-20 19:30 ` Felipe Balbi
2014-03-20 19:30 ` [PATCH 05/11] tty: serial: omap: switch over to devm_ioremap_resource Felipe Balbi
2014-03-20 19:30 ` Felipe Balbi
2014-03-20 19:30 ` [PATCH 06/11] tty: serial: omap: remove some dead code Felipe Balbi
2014-03-20 19:30 ` Felipe Balbi
2014-03-20 19:30 ` [PATCH 07/11] tty: serial: omap: remove unneeded singlethread workqueue Felipe Balbi
2014-03-20 19:30 ` Felipe Balbi
2014-03-20 19:30 ` [PATCH 08/11] In the uart_handle_cts_change(), uart_write_wakeup() is called after we call @uart_port->ops->start_tx() Felipe Balbi
2014-03-20 19:30 ` Felipe Balbi
2014-03-20 19:37 ` Felipe Balbi
2014-03-20 19:37 ` Felipe Balbi
2014-03-20 19:30 ` [PATCH 09/11] bluetooth: hci_ldisc: fix deadlock condition Felipe Balbi
2014-03-20 19:30 ` Felipe Balbi
2014-03-20 19:40 ` Marcel Holtmann
2014-03-20 20:17 ` Felipe Balbi
2014-03-20 20:17 ` Felipe Balbi
2014-03-27 0:47 ` Peter Hurley
2014-03-27 2:09 ` Felipe Balbi
2014-03-27 2:09 ` Felipe Balbi
2014-03-27 2:20 ` Peter Hurley
2014-03-27 2:20 ` Peter Hurley
2014-03-27 3:36 ` Felipe Balbi
2014-03-27 3:36 ` Felipe Balbi
2014-05-14 16:42 ` Dean Jenkins
2014-03-20 19:30 ` [PATCH 10/11] Revert "serial: omap: unlock the port lock" Felipe Balbi
2014-03-20 19:30 ` Felipe Balbi
2014-03-25 18:28 ` Tony Lindgren
2014-03-27 0:39 ` Peter Hurley [this message]
2014-03-27 2:10 ` Felipe Balbi
2014-03-27 2:10 ` Felipe Balbi
2014-03-27 2:27 ` Peter Hurley
2014-03-27 2:27 ` Peter Hurley
2014-03-27 3:37 ` Felipe Balbi
2014-03-27 3:37 ` Felipe Balbi
2014-03-27 14:54 ` Karicheri, Muralidharan
2014-03-20 19:30 ` [PATCH 11/11] serial: fix UART_IIR_ID Felipe Balbi
2014-03-20 19:30 ` Felipe Balbi
2014-04-22 14:22 ` [PATCH 01/11] tty: serial: add missing braces Felipe Balbi
2014-04-22 14:22 ` Felipe Balbi
2014-04-23 0:28 ` Greg KH
2014-04-23 14:53 ` Felipe Balbi
2014-04-23 14:53 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5333732F.6040803@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=b32955@freescale.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.