From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [memnic PATCH 15/16] pmd: remove useless makefile
 variables
Date: Thu, 27 Mar 2014 09:45:51 +0100
Message-ID: <5333E53F.2050209@6wind.com>
References: <1391529271-24606-1-git-send-email-thomas.monjalon@6wind.com>
 <1391529271-24606-16-git-send-email-thomas.monjalon@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1391529271-24606-16-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On 02/04/2014 04:54 PM, Thomas Monjalon wrote:
> Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> ---
>   pmd/Makefile |    7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/pmd/Makefile b/pmd/Makefile
> index 730b126..5edc44e 100644
> --- a/pmd/Makefile
> +++ b/pmd/Makefile
> @@ -29,10 +29,7 @@
>   # ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
>   # OF THE POSSIBILITY OF SUCH DAMAGE.
>
> -PKG = librte_pmd_memnic_copy
> -
> -RTE_CONFIG = $(RTE_INCLUDE)/rte_config.h
> -SOLIB = $(PKG).so
> +SOLIB = librte_pmd_memnic_copy.so
>   DOC = dpdk-memnic.rst
>
>   S ?= .
> @@ -59,7 +56,7 @@ ifeq '$(RTE_INCLUDE)' ''
>   	@ echo 'ERROR: RTE_INCLUDE is not set' && false
>   endif
>   	$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) \
> -		-I$(RTE_INCLUDE) -include $(RTE_CONFIG) \
> +		-I$(RTE_INCLUDE) -include $(RTE_INCLUDE)/rte_config.h \
>   		-I$S/../common -o $@ $<
>
>   install : $(DESTDIR)$(libdir)/$(SOLIB)
>

Reviewed-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>