From: Daniel Mack <zonque@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ASoC: davinci-mcasp: set up channel status bits for S/PDIF mode
Date: Thu, 27 Mar 2014 11:26:36 +0100 [thread overview]
Message-ID: <5333FCDC.3070809@gmail.com> (raw)
In-Reply-To: <5333F5E8.8080506@ti.com>
Hi Peter,
On 03/27/2014 10:56 AM, Peter Ujfalusi wrote:
> On 03/27/2014 11:49 AM, Daniel Mack wrote:
>> + u32 val = 0;
>> + u8 *bytes = (u8*) &val;
>
> Would it be better to call these variables as:
> u32 cs; /* as in Channel Status */
> u8 *cs_bytes = (u8*) &cs; /* Channel Status in bytes */
>
> Without the comments of course.
> Sorry, I did not noticed this previously...
No problem. v3 coming up.
> Otherwise it looks good, does it work? ;)
It does! :)
Daniel
prev parent reply other threads:[~2014-03-27 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 9:49 [PATCH v2] ASoC: davinci-mcasp: set up channel status bits for S/PDIF mode Daniel Mack
2014-03-27 9:56 ` Peter Ujfalusi
2014-03-27 10:26 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5333FCDC.3070809@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.