From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org
Subject: Re: [RFC] drm/i915: Simplify page allocation loop a bit
Date: Thu, 27 Mar 2014 10:40:42 +0000 [thread overview]
Message-ID: <5334002A.7050302@linux.intel.com> (raw)
In-Reply-To: <1395915537-11086-1-git-send-email-tvrtko.ursulin@linux.intel.com>
On 03/27/2014 10:18 AM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Looks like there are some redundant lines in the main loop of
> i915_gem_object_get_pages_gtt.
>
> v2: Put CONFIG_SWIOTLB back in.
>
> I haven't tested this so just RFC please. Not sure that
> seven lines net less is worth this. It just made it clerer
> to a newby to sg building to think of it in terms of
> "merge entries always except when...".
For what it is worth, this builds and doesn't blow up on some smoke tests.
Tvrtko
prev parent reply other threads:[~2014-03-27 10:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 16:48 [RFC] drm/i915: Simplify page allocation loop a bit Tvrtko Ursulin
2014-03-26 16:58 ` Imre Deak
2014-03-26 17:11 ` Chris Wilson
2014-03-26 17:33 ` Tvrtko Ursulin
2014-03-27 10:18 ` Tvrtko Ursulin
2014-03-27 10:40 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5334002A.7050302@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.