All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,
	mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCHv2] block: optimize zero writes with bdrv_write_zeroes
Date: Thu, 27 Mar 2014 14:06:57 +0100	[thread overview]
Message-ID: <53342271.5070803@kamp.de> (raw)
In-Reply-To: <87fvm5720l.fsf@blackfin.pond.sub.org>

On 26.03.2014 10:16, Markus Armbruster wrote:
> Peter Lieven <pl@kamp.de> writes:
>
>> this patch tries to optimize zero write requests
>> by automatically using bdrv_write_zeroes if it is
>> supported by the format.
>>
>> this should significantly speed up file system initialization and
>> should speed zero write test used to test backend storage performance.
>>
>> the difference can simply be tested by e.g.
>>
>> dd if=/dev/zero of=/dev/vdX bs=1M
> Got actual numbers?  Preferably for some operation that matters to
> users.

To give you a rough figure I have an iSCSI Storage for testing that
has an 1GBit connection. The above command gives about 110MB/s
with detect-zeroes=off and about 980MB/s with detect-zeroes=unmap.

Additionally I ran a test with v1 of the patch:

---8<---

I created a 60GB qcow2 container and formatted it with ext4. To immediately show the difference
I disabled lazy inode table and lazy journal init (writing zero takes place immediately then).

Timing without the patch:
time mkfs.ext4 -E lazy_itable_init=0,lazy_journal_init=0 /dev/vda
real 1m5.649s
user 0m0.416s
sys  0m3.148s

Timing with the patch:
time mkfs.ext4 -E lazy_itable_init=0,lazy_journal_init=0 /dev/vdX
real 0m1.228s
user 0m0.116s
sys  0m0.732s

Container Size after Format without the patch: 1150615552 Byte (1097.3MB)
Container Size after Format with the patch: 24645632 Byte (23.5MB)

--->8---

Without the patch means detect-zeroes=off (default) and with the patch means detect-zeroes=unmap.

BR,
Peter

  reply	other threads:[~2014-03-27 13:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-21 14:36 [Qemu-devel] [RFC PATCHv2] block: optimize zero writes with bdrv_write_zeroes Peter Lieven
2014-03-21 14:50 ` Eric Blake
2014-03-21 20:20   ` Peter Lieven
2014-03-26  9:16 ` Markus Armbruster
2014-03-27 13:06   ` Peter Lieven [this message]
2014-03-27 14:07     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53342271.5070803@kamp.de \
    --to=pl@kamp.de \
    --cc=armbru@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.