Re: [Qemu-devel] [PATCH v6] net: L2TPv3 transport

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

On 03/26/2014 05:08 AM, anton.ivanov@kot-begemot.co.uk wrote:
> From: Anton Ivanov <antivano@cisco.com>
> 
> This transport allows to connect a QEMU nic to a static Ethernet
> over L2TPv3 tunnel. The transport supports all options present
> in the Linux kernel implementation. It allows QEMU to connect
> to any Linux host running kernel 3.3+, most routers and network
> devices as well as other QEMU instances.
> 
> Signed-off-by: Anton Ivanov <antivano@cisco.com>
> ---

>  #
>  # Since 1.2
> -##
> +#
> +# Added in 2.1 - l2tpv3
> +#
>  { 'union': 'NetClientOptions',

Minor nit - you lost the ## end-of-comment line.  Also, see how QKeyCode
mentioned added values:

# Since: 1.3.0
#
# 'unmapped' and 'pause' since 2.0
##

We haven't done this sort of addition much to date, but it can't hurt to
use a consistent style when doing so.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]