From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTA8k-0001bR-RC for qemu-devel@nongnu.org; Thu, 27 Mar 2014 09:14:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTA8b-0003c0-Q4 for qemu-devel@nongnu.org; Thu, 27 Mar 2014 09:14:38 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:61632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTA8b-0003bo-KM for qemu-devel@nongnu.org; Thu, 27 Mar 2014 09:14:29 -0400 Received: by mail-pa0-f47.google.com with SMTP id lj1so3453717pab.34 for ; Thu, 27 Mar 2014 06:14:28 -0700 (PDT) Message-ID: <5334242E.1010806@ozlabs.ru> Date: Fri, 28 Mar 2014 00:14:22 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1395886880-11021-1-git-send-email-aik@ozlabs.ru> <1395886880-11021-3-git-send-email-aik@ozlabs.ru> <53341281.8090907@redhat.com> In-Reply-To: <53341281.8090907@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] spapr: Define NMI interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= On 03/27/2014 10:58 PM, Paolo Bonzini wrote: > Il 27/03/2014 03:21, Alexey Kardashevskiy ha scritto: >> This defines and makes use of an NMI interface in order to support >> the "nmi" command. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> hw/ppc/spapr.c | 26 ++++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c >> index 62ddb4d..495fa88 100644 >> --- a/hw/ppc/spapr.c >> +++ b/hw/ppc/spapr.c >> @@ -48,6 +48,7 @@ >> #include "hw/pci/pci.h" >> #include "hw/scsi/scsi.h" >> #include "hw/virtio/virtio-scsi.h" >> +#include "hw/nmi.h" >> >> #include "exec/address-spaces.h" >> #include "hw/usb.h" >> @@ -1539,13 +1540,36 @@ static char *spapr_get_fw_dev_path(FWPathProvider >> *p, BusState *bus, >> return NULL; >> } >> >> +static void spapr_do_nmi(void *arg) >> +{ >> + CPUState *cs = arg; >> + PowerPCCPU *cpu = POWERPC_CPU(cs); >> + CPUPPCState *env = &cpu->env; >> + >> + cpu_synchronize_state(cs); >> + env->spr[SPR_SRR0] = env->nip; >> + env->spr[SPR_SRR1] = env->msr; >> + env->nip = 0x100; >> + env->msr = (1ULL << MSR_SF) | (1 << MSR_ME); >> + if (env->spr[SPR_LPCR] & LPCR_ILE) { >> + env->msr |= 1 << MSR_LE; >> + } >> +} > > > I think an interface isn't the right tool here. You want a method in > CPUClass, and you also should move the existing code for x86 and s390 to > target-i386 and target-s390. I can do that, no big deal (bit afraid there will be some third approach then :) ), but 1) how many x86 CPUs/families are there to support? On ppc I'll add it for POWER7/7+/8 families and I am ok. 2) what should "nmi" really do - deliver NMI to the current CPU (as s390 does) or on all CPUs (as x86 does)? -- Alexey