All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Yang <liezhi.yang@windriver.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/4] gummiboot: add COMPATIBLE_HOST
Date: Thu, 27 Mar 2014 22:48:18 +0800	[thread overview]
Message-ID: <53343A32.6070109@windriver.com> (raw)
In-Reply-To: <20140327113949.GQ3709@jama>



On 03/27/2014 07:39 PM, Martin Jansa wrote:
> On Thu, Mar 27, 2014 at 04:11:22AM -0400, Robert Yang wrote:
>> The gummiboot depends on gnu-efi which had set:
>>
>> COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"
>>
>> We also need set this for gummiboot, otherwise there would be build
>> failures for other non-x86 archs.
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   meta/recipes-bsp/gummiboot/gummiboot_git.bb |    2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-bsp/gummiboot/gummiboot_git.bb b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
>> index 5868a23..61de58c 100644
>> --- a/meta/recipes-bsp/gummiboot/gummiboot_git.bb
>> +++ b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
>> @@ -13,6 +13,8 @@ PV = "43+git${SRCPV}"
>>   SRCREV = "4062c51075ba054d4949c714fe06123f9ad3097d"
>>   SRC_URI = "git://anongit.freedesktop.org/gummiboot"
>>
>
> It would be good to add comment here saying it's only because of gnu-efi
> dependency (if gummiboot itself can in theory work on other hosts).
>

Sounds reasonable, updated:

   git://git.openembedded.org/openembedded-core-contrib rbt/gummiboot
 
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/gummiboot

diff --git a/meta/recipes-bsp/gummiboot/gummiboot_git.bb 
b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
index 61de58c..035cec1 100644
--- a/meta/recipes-bsp/gummiboot/gummiboot_git.bb
+++ b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
@@ -13,6 +13,9 @@ PV = "43+git${SRCPV}"
  SRCREV = "4062c51075ba054d4949c714fe06123f9ad3097d"
  SRC_URI = "git://anongit.freedesktop.org/gummiboot"

+# Note: Add COMPATIBLE_HOST here is only because it depends on gnu-efi
+# which has set the COMPATIBLE_HOST, the gummiboot itself may work on
+# more hosts.
  COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"

  S = "${WORKDIR}/git"

// Robert


> People won't notice it in commit message when they are looking at
> recipe.
>
>> +COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"
>> +
>>   S = "${WORKDIR}/git"
>>
>>   EXTRA_OECONF = "--disable-manpages --with-efi-includedir=${STAGING_INCDIR} \
>> --
>> 1.7.10.4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>


  reply	other threads:[~2014-03-27 14:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27  8:11 [PATCH 0/4] fixes for gummiboot and gnu-efi Robert Yang
2014-03-27  8:11 ` [PATCH 1/4] gnu-efi: fix the LIBDIR Robert Yang
2014-03-27  8:11 ` [PATCH 2/4] gummiboot: add COMPATIBLE_HOST Robert Yang
2014-03-27 11:39   ` Martin Jansa
2014-03-27 14:48     ` Robert Yang [this message]
2014-03-27 14:54       ` Robert Yang
2014-03-27 16:08   ` Khem Raj
2014-03-27 20:45     ` Fathi Boudra
2014-03-27  8:11 ` [PATCH 3/4] gummiboot: use objcopy from the env Robert Yang
2014-03-28  0:49   ` Khem Raj
2014-03-28  3:02     ` Robert Yang
2014-03-27  8:11 ` [PATCH 4/4] gummiboot: fix the installed but not shipped warning Robert Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53343A32.6070109@windriver.com \
    --to=liezhi.yang@windriver.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.