From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTCPy-0004bX-1W for qemu-devel@nongnu.org; Thu, 27 Mar 2014 11:40:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTCPs-0006t4-1T for qemu-devel@nongnu.org; Thu, 27 Mar 2014 11:40:33 -0400 Message-ID: <5334466A.3020803@suse.de> Date: Thu, 27 Mar 2014 16:40:26 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1395715231-4217-1-git-send-email-anton@samba.org> <1395715231-4217-6-git-send-email-anton@samba.org> <533421A6.6030007@ozlabs.ru> In-Reply-To: <533421A6.6030007@ozlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 6/6] target-ppc: Add PMC7/8 to 970 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , Anton Blanchard Cc: clg@fr.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, gkurz@linux.vnet.ibm.com Am 27.03.2014 14:03, schrieb Alexey Kardashevskiy: > On 03/25/2014 01:40 PM, Anton Blanchard wrote: >> 970 CPUs have PMC7/8. Create gen_spr_970 to avoid replicating >> it 3 times, and simplify the existing code. >> >> Signed-off-by: Anton Blanchard >> --- >> target-ppc/translate_init.c | 89 ++++++++++++++++++++----------------= --------- >> 1 file changed, 39 insertions(+), 50 deletions(-) >> >> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c >> index 273e37d..50b2603 100644 >> --- a/target-ppc/translate_init.c >> +++ b/target-ppc/translate_init.c >> @@ -6747,12 +6747,13 @@ static void gen_spr_book3s (CPUPPCState *env) >> 0x00000000); >> } >> =20 >> -static void init_proc_970 (CPUPPCState *env) >> +static void gen_spr_970 (CPUPPCState *env) >> { >> - gen_spr_ne_601(env); >> - gen_spr_book3s(env); >> - /* Time base */ >> - gen_tbl(env); >> + spr_register(env, SPR_HIOR, "SPR_HIOR", >=20 >=20 > + spr_register(env, SPR_HIOR, "HIOR", >=20 > Can we please not add SPR_ in string name? Thanks. As far I see, this is only being moved around, not added here. If this is not user ABI, feel free to first drop it, then move it. Similarly, adding the new ones in a third step would make review and bisection easier. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg