All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Neil Zhang <zhangwm@marvell.com>, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] timekeeping: check params before use them
Date: Thu, 27 Mar 2014 10:26:24 -0700	[thread overview]
Message-ID: <53345F40.70608@linaro.org> (raw)
In-Reply-To: <1395907978-6202-1-git-send-email-zhangwm@marvell.com>

On 03/27/2014 01:12 AM, Neil Zhang wrote:
> Sometimes we won't need all the information from
> get_xtime_and_monotonic_and_sleep_offset(),
> so let's check the params before assign the value to them.

So I think the single in-kernel user of this function does use all of
the information.

Can you expand on how your using this and why the extra conditionals are
worth while?

thanks
-john


  reply	other threads:[~2014-03-27 17:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27  8:12 [PATCH] timekeeping: check params before use them Neil Zhang
2014-03-27 17:26 ` John Stultz [this message]
2014-03-28  1:13   ` Neil Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53345F40.70608@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=zhangwm@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.