From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa0-f48.google.com (mail-oa0-f48.google.com [209.85.219.48]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 84869E00AB5 for ; Thu, 27 Mar 2014 12:02:02 -0700 (PDT) Received: by mail-oa0-f48.google.com with SMTP id m1so4846363oag.21 for ; Thu, 27 Mar 2014 12:02:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=c64oGTSuPr8RdxCCtzvZxNAJeH672zD+MTlnOHIz1MM=; b=R8FUjeM2LwYAP3WjvRu6aRF5FgcqnKOjcAZYysJniRijcq9SqMaj0hfwyLNqlN5dLv a6FFskB7BGw4IgA8T1Krf0EWcQisNo7e4vn7YE372rQuxz/lbTwjLiFYDmUbVHSZlLbK Q1CUzFZpXlaMaiDigaq883Xcn2qF0iYFgyYArLJHsn8HMNmmKLfvXzHsz4h0z3YReE5I HdK2QMbDPQc097tWEJrD5ouYcJK64djlzwsSQmXQ21YxjiM8xsE0QTXJHuUcuQOvDztJ eR3HlpEy/QSMhiPyVcWBd4w4mQVRoE7K8FeROe7+lm5NWxi/FuMz6vThbyrlJ8TKd33j bftA== X-Gm-Message-State: ALoCoQmOElPvcBcpjsGcQXSOvScg40cdJmmenv5+Y+WAsaP0ijkrBim3OieHRkf7GCOmnYhSO51M X-Received: by 10.60.37.99 with SMTP id x3mr2949771oej.2.1395946921117; Thu, 27 Mar 2014 12:02:01 -0700 (PDT) Received: from [192.168.141.83] (69-165-220-158.dsl.teksavvy.com. [69.165.220.158]) by mx.google.com with ESMTPSA id su13sm11524800oeb.9.2014.03.27.12.02.00 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 27 Mar 2014 12:02:00 -0700 (PDT) Message-ID: <533475A7.30402@linaro.org> Date: Thu, 27 Mar 2014 15:01:59 -0400 From: Trevor Woerner User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: "Daiane.Angolini@freescale.com" , "meta-freescale@yoctoproject.org" References: <1395862407-29020-1-git-send-email-trevor.woerner@linaro.org> <9f280c59d8d64d4a97232eb0d5d00fc4@BY2PR03MB379.namprd03.prod.outlook.com> <53344FF5.90605@linaro.org> <8c297336348146d7942cf23214321aa7@BY2PR03MB379.namprd03.prod.outlook.com> In-Reply-To: <8c297336348146d7942cf23214321aa7@BY2PR03MB379.namprd03.prod.outlook.com> Subject: Re: [PATCH][fsl-community-bsp-base] setup-environment: provide a MACHINE menu X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2014 19:02:02 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit On 03/27/14 14:08, Daiane.Angolini@freescale.com wrote: >> Traditionally I've been hesitant to send patches, but I've decided to not >> be as shy anymore. Therefore I don't expect everything I send to be >> successful :-) > Yes, please, don't be shy anymore and send all patches you have ;-) The can of worms is now open :-) > I like your patch. But it have several important problems. > > 1) assign a number to a board may lead user to error. I love the machine list, and I love that imx53qsb is 20, but when a new board is added I will try to use 20 and it will not be imx53qsb. This is only one example, and this only happens if you use a dynamic order for the machine list. I hadn't thought of that, but I agree completely. > 2) it only list machines from meta-fsl-arm and meta-fsl-arm-extra. I tried > > MACHINE="qemuarm" source setup-environment build > > And I faced a big error message! Whoops! I hadn't tested the emulators, but I agree they should certainly be in the list too. Getting a big error message isn't what I wanted to have happen. > I´m not sure if we want to list external boards, but it looks weird to me not being able to have a qemu build dir. By "external boards" I assume you mean non-ARM or non-freescale boards (e.g. beagle)? If so, I don't think we should worry too much about listing external boards, setup-environment comes from a freescale-specific repository. If someone is following the steps to checkout and build for a freescale board (and therefore using setup-environment), I think it's a safe enough assumption they're going to want to build for one of the boards supported by the freescale BSP repositories (or qemu). I don't think it's too much to say that someone would be in the wrong place if they were complaining that the freescale setup script didn't include options to build for a MIPS64 target :-) In other words, I believe the setup-environment script provided in fsl-community-bsp-base is already freescale-specific. Making it more so shouldn't be a problem? > 3) In error message, instead of list all boards one before the other, list one machine per line. Okay. > I like to prompt user instead of assuming a default machine. But a list of machines is not good when you have 150 machines. And I start to try to group the machines in SOC family, or in meta-fsl-arm/meta-fsl-arm-extra, or any other criteria to help user to decide it. Actually, an early version of my script did that, but I thought it was too "text-y" so I shortened it to just the machine name. I figure the person has the board sitting there, they know the board name, so finding that name in a list that is sorted alphabetically shouldn't be too hard :-D But in this decision you can also see my bias. I don't look at the boards as being either from freescale or not, so sorting them that way is not something I would do by default :-)