From: Don Slutz <dslutz@verizon.com>
To: Ian Campbell <Ian.Campbell@citrix.com>, Don Slutz <dslutz@verizon.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
xen-devel@lists.xen.org, Ian Jackson <ian.jackson@eu.citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v5 04/17] xenctx: Add command line options -b (--bytes-per-line) and -l (--lines)
Date: Thu, 27 Mar 2014 15:36:07 -0400 [thread overview]
Message-ID: <53347DA7.2040200@terremark.com> (raw)
In-Reply-To: <1395935722.22909.168.camel@kazak.uk.xensource.com>
On 03/27/14 11:55, Ian Campbell wrote:
> On Mon, 2014-03-24 at 12:58 -0400, Don Slutz wrote:
>> On 03/24/14 06:44, Ian Campbell wrote:
> I think we are way past intrusive...
>
Source code yes. Output before v8 by default no.
The v8 drop of -T is the 1st visible change from just running it.
> Please can you get out of the habit of just cutting and pasting emails
> in response to questions, it's very hard to make sense of what you are
> trying to say when you do this. Just answer the question directly.
Still adjusting to the right level. Sorry about the cost to you.
[...]
> I don't want things over 80 columns either.
>
> I want to know that you have thought about the tradeoffs of adding a new
> option and concluded that a new option is better than changing the
> defaults -- the obvious way to stop me questioning this sort of thing
> would be to explain the choice in the commit message in the first place.
Good to know. I hope the commit message changes in v8 help.
-Don Slutz
> Ian.
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-03-27 19:36 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 19:06 [PATCH v5 00/17] xenctx: Many changes Don Slutz
2014-03-20 19:06 ` [PATCH v5 01/17] xenctx: clean up usage output Don Slutz
2014-03-21 14:21 ` Ian Campbell
2014-03-20 19:06 ` [PATCH v5 02/17] xenctx: Clean up stack trace when hypercall_page not in symbol table Don Slutz
2014-03-20 19:06 ` [PATCH v5 03/17] xenctx: Add -n (--display-stack-pages) option to output larger stack Don Slutz
2014-03-21 14:29 ` Ian Campbell
2014-03-22 20:49 ` Don Slutz
2014-03-24 10:39 ` Ian Campbell
2014-03-24 13:26 ` Don Slutz
2014-03-20 19:06 ` [PATCH v5 04/17] xenctx: Add command line options -b (--bytes-per-line) and -l (--lines) Don Slutz
2014-03-21 14:32 ` Ian Campbell
2014-03-22 20:08 ` Don Slutz
2014-03-22 20:10 ` Don Slutz
2014-03-24 10:44 ` Ian Campbell
2014-03-24 16:58 ` Don Slutz
2014-03-27 15:55 ` Ian Campbell
2014-03-27 19:36 ` Don Slutz [this message]
2014-03-20 19:06 ` [PATCH v5 05/17] xenctx: Add command line option -D (--decode-as-ascii) Don Slutz
2014-03-21 14:38 ` Ian Campbell
2014-03-21 18:42 ` Don Slutz
2014-03-24 10:46 ` Ian Campbell
2014-03-24 17:00 ` Don Slutz
2014-03-20 19:06 ` [PATCH v5 06/17] xenctx: Add command line option -t (--tag-stack-dump) Don Slutz
2014-03-21 14:40 ` Ian Campbell
2014-03-20 19:06 ` [PATCH v5 07/17] xenctx: Change print_symbol to do the space before Don Slutz
2014-03-20 19:06 ` [PATCH v5 08/17] xenctx: More info on failed to map page Don Slutz
2014-03-20 19:06 ` [PATCH v5 09/17] xenctx: Add command line option -T (--tag-trace) Don Slutz
2014-03-21 14:44 ` Ian Campbell
2014-03-24 19:54 ` Don Slutz
2014-03-27 15:56 ` Ian Campbell
2014-03-20 19:06 ` [PATCH v5 10/17] xenctx: Add -m (--memory) <maddr> option to dump memory at maddr Don Slutz
2014-03-21 14:53 ` Ian Campbell
2014-03-25 19:16 ` Don Slutz
2014-03-20 19:06 ` [PATCH v5 11/17] xenctx: Add -d (--dump-as-stack) <daddr> option to dump memory at daddr as a stack Don Slutz
2014-03-21 14:57 ` Ian Campbell
2014-03-24 15:22 ` Don Slutz
2014-03-27 15:58 ` Ian Campbell
2014-03-27 17:05 ` Don Slutz
2014-03-27 17:20 ` Ian Campbell
2014-03-27 17:49 ` Don Slutz
2014-03-20 19:07 ` [PATCH v5 12/17] xenctx: change is_kernel_text() into kernel_addr() Don Slutz
2014-03-21 15:02 ` Ian Campbell
2014-03-21 17:45 ` Don Slutz
2014-03-24 22:23 ` Don Slutz
2014-03-25 9:13 ` Jan Beulich
2014-03-27 15:59 ` Ian Campbell
2014-03-20 19:07 ` [PATCH v5 13/17] xenctx: Add convert of more registers to symbols Don Slutz
2014-03-21 10:24 ` Jan Beulich
2014-03-21 12:34 ` Don Slutz
2014-03-21 14:11 ` [PATCH v6 " Don Slutz
2014-03-21 14:45 ` Jan Beulich
2014-03-21 17:43 ` [PATCH v7 " Don Slutz
2014-03-24 10:51 ` Ian Campbell
2014-03-21 15:03 ` [PATCH v6 " Ian Campbell
2014-03-21 17:38 ` Don Slutz
2014-03-21 15:07 ` [PATCH v5 " Ian Campbell
2014-03-21 15:11 ` Jan Beulich
2014-03-21 16:06 ` Ian Campbell
2014-03-21 18:16 ` Don Slutz
2014-03-24 10:49 ` Ian Campbell
2014-03-24 14:09 ` Don Slutz
2014-03-27 16:06 ` Ian Campbell
2014-03-27 16:52 ` Don Slutz
2014-03-20 19:07 ` [PATCH v5 14/17] xenctx: Add output of vcpu value and state for --all-vcpus Don Slutz
2014-03-27 16:07 ` Ian Campbell
2014-03-20 19:07 ` [PATCH v5 15/17] xenctx: Fix handling of !guest_protected_mode Don Slutz
2014-03-21 15:09 ` Ian Campbell
2014-03-24 22:35 ` Don Slutz
2014-03-20 19:07 ` [PATCH v5 16/17] xenctx: Allow output for offline vcpu when specified Don Slutz
2014-03-21 15:11 ` Ian Campbell
2014-03-24 13:20 ` Don Slutz
2014-03-20 19:07 ` [PATCH v5 17/17] xenctx: Fixup options checking Don Slutz
2014-03-21 15:13 ` Ian Campbell
2014-03-24 14:26 ` Don Slutz
2014-03-27 16:10 ` Ian Campbell
2014-03-21 15:14 ` [PATCH v5 00/17] xenctx: Many changes Ian Campbell
2014-03-21 17:37 ` Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53347DA7.2040200@terremark.com \
--to=dslutz@verizon.com \
--cc=Ian.Campbell@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.