All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, lars@metafoo.de, neumann@teufel.de,
	brandau@gmx.de
Subject: Re: [PATCH] ASoC: sta350: Add codec driver
Date: Thu, 27 Mar 2014 20:43:12 +0100	[thread overview]
Message-ID: <53347F50.5020303@gmail.com> (raw)
In-Reply-To: <20140327172127.GS30768@sirena.org.uk>

Hi Mark,

On 03/27/2014 06:21 PM, Mark Brown wrote:
> On Thu, Mar 27, 2014 at 05:18:02PM +0100, Daniel Mack wrote:
>> From: Sven Brandau <brandau@gmx.de>
>>
>> The TI STA350 is an integrated 2.1-channel power amplifier that is
>> controllable over I2C. This patch adds an ASoC driver for it.
>>
>> At a glance, this chip is very similar to the STA320 for which a driver
>> already exists. In details, however, the register maps contain subtle
>> differences which made a whole new driver easier to write and maintain.
> 
> A few issues below, some may already be present in the sta320 driver,
> generally newer idioms and so on, but that's no reason to not fix them
> here!

Thanks a lot for your review! Much appreciated.

All points are agreed upon, and are already fixed locally. Will send a
v2 soon.


Daniel

      reply	other threads:[~2014-03-27 19:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27 16:18 [PATCH] ASoC: sta350: Add codec driver Daniel Mack
2014-03-27 17:21 ` Mark Brown
2014-03-27 19:43   ` Daniel Mack [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53347F50.5020303@gmail.com \
    --to=zonque@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=brandau@gmx.de \
    --cc=broonie@kernel.org \
    --cc=lars@metafoo.de \
    --cc=neumann@teufel.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.