From: Vlad Yasevich <vyasevic@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH v2 net] vlan: Mask off vlan acceleration features on vlan device.
Date: Thu, 27 Mar 2014 16:25:41 -0400 [thread overview]
Message-ID: <53348945.6070301@redhat.com> (raw)
In-Reply-To: <20140327.151205.1227455812702138170.davem@davemloft.net>
On 03/27/2014 03:12 PM, David Miller wrote:
> From: Vlad Yasevich <vyasevic@redhat.com>
> Date: Wed, 26 Mar 2014 16:28:31 -0400
>
>> Some drivers incorrectly assign vlan acceleration features to
>> vlan_features thus causing issues for Q-in-Q vlan configurations.
>> Prevent this once and for all by masking off acceleration features
>> for vlan devices until such time as we support stacked acceleration.
>>
>> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
>
> Vlad, I've thought more about this, I'd rather we emit a warning so
> we can fix the drivers.
>
> If they are setting the flags wrong, we probably want to go take a
> look to see if they are doing anything else related wrong too.
>
OK. I'll rework the patch to emit a warning. I took a quick glance
through all the devices that set vlan_features and there are 3 more
the have vlan_features wrong. I'll include those when I re-submit.
Thanks
-vlad
prev parent reply other threads:[~2014-03-27 20:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 21:52 [PATCH] tg3: Do not include vlan acceleration features in vlan_features Vlad Yasevich
2014-03-26 19:56 ` David Miller
2014-03-26 20:25 ` [PATCH net] vlan: Mask off vlan acceleration features on vlan device Vlad Yasevich
2014-03-26 20:26 ` Vlad Yasevich
2014-03-26 20:28 ` [PATCH v2 " Vlad Yasevich
2014-03-26 21:10 ` David Miller
2014-03-26 21:15 ` Patrick McHardy
2014-03-27 0:53 ` Vlad Yasevich
2014-03-27 8:14 ` Patrick McHardy
2014-03-27 1:03 ` Vlad Yasevich
2014-03-27 19:12 ` David Miller
2014-03-27 20:25 ` Vlad Yasevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53348945.6070301@redhat.com \
--to=vyasevic@redhat.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.