From: Julien Grall <julien.grall@linaro.org>
To: Suriyan Ramasami <suriyan.r@gmail.com>, xen-devel@lists.xen.org
Cc: Tim Deegan <tim@xen.org>,
ian.campbell@citrix.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [ARM:PATCH v2 1/1] Pass the timer clock-frequency to DOM0
Date: Thu, 27 Mar 2014 21:48:07 +0000 [thread overview]
Message-ID: <53349C97.2010204@linaro.org> (raw)
In-Reply-To: <1395892451-14191-1-git-send-email-suriyan.r@gmail.com>
Hello Suriyan,
(Adding the other Xen ARM maintainers).
Thank you for the patch. Xen-devel starts to have a big traffic, we use
to cc maintainers on patches. You can find them via
script/get_maintainers.pl
On 27/03/14 03:54, Suriyan Ramasami wrote:
> xen/arm: Pass the timer "clock-frequency" to DOM0 in make_timer_node
You guess you are copying git show in an email? If so, I advise you to
read this website:
http://alblue.bandlem.com/2011/12/git-tip-of-week-patches-by-email.html
> If the DT representing the ARM generic timer mentions a clock-frequency,
> propragate it to the DT that is built for DOM0.
>
> This is necessary as a workaround for boards (Odroid-XU) where CNTFRQ is
> not set or returns a wrong value.
Do you have any plan to send a similar patch for domU?
>
> @@ -639,6 +641,9 @@ static int make_timer_node(const struct domain *d, void *fdt,
> return -FDT_ERR_XEN(ENOENT);
> }
>
> + clock_valid = dt_property_read_u32(dev, "clock-frequency",
> + &clock_frequency);
> +
Can you gather all your changes in one place? I don't see why you need
to read the clock-frequency earlier.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-03-27 21:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 3:54 [ARM:PATCH v2 1/1] Pass the timer clock-frequency to DOM0 Suriyan Ramasami
2014-03-27 21:48 ` Julien Grall [this message]
2014-03-27 22:16 ` Suriyan Ramasami
2014-03-28 14:04 ` Julien Grall
2014-04-01 11:12 ` Ian Campbell
2014-04-11 16:05 ` Suriyan Ramasami
2014-04-11 16:32 ` Julien Grall
2014-04-13 19:28 ` Suriyan Ramasami
2014-04-13 20:20 ` Julien Grall
2014-04-13 20:48 ` Suriyan Ramasami
2014-04-13 21:40 ` Julien Grall
2014-04-13 22:55 ` Suriyan Ramasami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53349C97.2010204@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=suriyan.r@gmail.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.