From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [ARM:PATCH v2 1/1] Pass the timer clock-frequency to DOM0 Date: Thu, 27 Mar 2014 21:48:07 +0000 Message-ID: <53349C97.2010204@linaro.org> References: <1395892451-14191-1-git-send-email-suriyan.r@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1395892451-14191-1-git-send-email-suriyan.r@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Suriyan Ramasami , xen-devel@lists.xen.org Cc: Tim Deegan , ian.campbell@citrix.com, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Hello Suriyan, (Adding the other Xen ARM maintainers). Thank you for the patch. Xen-devel starts to have a big traffic, we use to cc maintainers on patches. You can find them via script/get_maintainers.pl On 27/03/14 03:54, Suriyan Ramasami wrote: > xen/arm: Pass the timer "clock-frequency" to DOM0 in make_timer_node You guess you are copying git show in an email? If so, I advise you to read this website: http://alblue.bandlem.com/2011/12/git-tip-of-week-patches-by-email.html > If the DT representing the ARM generic timer mentions a clock-frequency, > propragate it to the DT that is built for DOM0. > > This is necessary as a workaround for boards (Odroid-XU) where CNTFRQ is > not set or returns a wrong value. Do you have any plan to send a similar patch for domU? > > @@ -639,6 +641,9 @@ static int make_timer_node(const struct domain *d, void *fdt, > return -FDT_ERR_XEN(ENOENT); > } > > + clock_valid = dt_property_read_u32(dev, "clock-frequency", > + &clock_frequency); > + Can you gather all your changes in one place? I don't see why you need to read the clock-frequency earlier. Regards, -- Julien Grall