Re: [PATCH 4/5] ARM: shmobile: Call sh_pm_runtime_init() from platform code on all SoCs

[Ben Dooks <ben.dooks@codethink.co.uk>]

On 27/03/14 20:05, Geert Uytterhoeven wrote:
> On Wed, Mar 19, 2014 at 8:06 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> Explicitly call sh_pm_runtime_init() from shmobile platform code on all
>> shmobile SoCs, to make sure the bus clocks are enabled for all devices.
>>
>> On ARCH_SHMOBILE_LEGACY, this duplicates the work done in the existing
>> core_initcall() in drivers/sh/pm_runtime.c, which will be removed later.
>> On ARCH_SHMOBILE_MULTI, this was missing, leading to disabled clocks,
>> depending on implicit reset state or on the bootloader.
>>
>> The call to sh_pm_runtime_init() is made from .machine_init(), which is
>> called from an arch_initcall(), i.e. after the old core_initcall().
>
>> diff --git a/arch/arm/mach-shmobile/setup-r8a7791.c b/arch/arm/mach-shmobile/setup-r8a7791.c
>> index a7e4966f5e18..03145c804f50 100644
>> --- a/arch/arm/mach-shmobile/setup-r8a7791.c
>> +++ b/arch/arm/mach-shmobile/setup-r8a7791.c
>> @@ -185,6 +185,7 @@ static const struct resource thermal_resources[] __initconst = {
>>
>>   void __init r8a7791_add_dt_devices(void)
>>   {
>> +       sh_pm_runtime_init();
>
> For koelsch-legacy, this is actually too late: some platform devices
> (pfc, gpio_rcar) have been registered already.
>

IIRC the clock code looks for driver bind/unbind?


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius