From: Ding Tianhong <dingtianhong@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <ben@decadent.org.uk>, <john.r.fastabend@intel.com>,
<kaber@trash.net>, <netdev@vger.kernel.org>,
<f.fainelli@gmail.com>
Subject: Re: [PATCH net v2] vlan: Fix lockdep warning when vlan dev handle notification
Date: Fri, 28 Mar 2014 09:13:27 +0800 [thread overview]
Message-ID: <5334CCB7.9040703@huawei.com> (raw)
In-Reply-To: <20140327.130604.103963458048959251.davem@davemloft.net>
On 2014/3/28 1:06, David Miller wrote:
> From: Ding Tianhong <dingtianhong@huawei.com>
> Date: Mon, 17 Mar 2014 11:08:37 +0800
>
>> On 2014/3/15 10:02, David Miller wrote:
>>> From: Ding Tianhong <dingtianhong@huawei.com>
>>> Date: Thu, 13 Mar 2014 10:22:18 +0800
>>>
>>>> When I open the LOCKDEP config and run these steps:
>>>
>>> This doesn't work?
>>>
>>
>> It make no sense, I have try it before, the class check only focus on the lock_class_key,
>> not the lockdep_subclass_key.
>
> I think the issue is that not all of the addrlist locking uses _nested() variants,
> I think if we do that, this will all work.
>
> I do not want to add a huge array of locking keys to fix this, it's a waste of
> static kernel memory and inelegant.
>
>
OK, ready for fix this again with new idea, thanks.
Ding
prev parent reply other threads:[~2014-03-28 1:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 2:22 [PATCH net v2] vlan: Fix lockdep warning when vlan dev handle notification Ding Tianhong
2014-03-13 19:52 ` David Miller
2014-03-14 1:43 ` Ding Tianhong
2014-03-15 2:02 ` David Miller
2014-03-17 3:08 ` Ding Tianhong
2014-03-27 17:06 ` David Miller
2014-03-28 1:13 ` Ding Tianhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5334CCB7.9040703@huawei.com \
--to=dingtianhong@huawei.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.