From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5334ED77.4080601@lab.ntt.co.jp> Date: Fri, 28 Mar 2014 12:33:11 +0900 From: Toshiaki Makita MIME-Version: 1.0 References: <1395971478-10689-1-git-send-email-vyasevic@redhat.com> In-Reply-To: <1395971478-10689-1-git-send-email-vyasevic@redhat.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v2] bridge: Fix crash with vlan filtering and tcpdump List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vlad Yasevich , netdev@vger.kernel.org Cc: bridge@lists.linux-foundation.org (2014/03/28 10:51), Vlad Yasevich wrote: > When the vlan filtering is enabled on the bridge, but > the filter is not configured on the bridge device itself, > running tcpdump on the bridge device will result in a > an Oops with NULL pointer dereference. The reason > is that br_pass_frame_up() will bypass the vlan > check because promisc flag is set. It will then try > to get the table pointer and process the packet based > on the table. Since the table pointer is NULL, we oops. > Catch this special condition in br_handle_vlan(). > > Reported-by: Toshiaki Makita > CC: Toshiaki Makita > Signed-off-by: Vlad Yasevich Thanks, Acked-by: Toshiaki Makita From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshiaki Makita Subject: Re: [PATCH v2] bridge: Fix crash with vlan filtering and tcpdump Date: Fri, 28 Mar 2014 12:33:11 +0900 Message-ID: <5334ED77.4080601@lab.ntt.co.jp> References: <1395971478-10689-1-git-send-email-vyasevic@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: bridge@lists.linux-foundation.org To: Vlad Yasevich , netdev@vger.kernel.org Return-path: In-Reply-To: <1395971478-10689-1-git-send-email-vyasevic@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org (2014/03/28 10:51), Vlad Yasevich wrote: > When the vlan filtering is enabled on the bridge, but > the filter is not configured on the bridge device itself, > running tcpdump on the bridge device will result in a > an Oops with NULL pointer dereference. The reason > is that br_pass_frame_up() will bypass the vlan > check because promisc flag is set. It will then try > to get the table pointer and process the packet based > on the table. Since the table pointer is NULL, we oops. > Catch this special condition in br_handle_vlan(). > > Reported-by: Toshiaki Makita > CC: Toshiaki Makita > Signed-off-by: Vlad Yasevich Thanks, Acked-by: Toshiaki Makita