Re: [dpdk-stable] [PATCH] lib/librte_cmdline: fix CLI parsing issue

[Thomas Monjalon <thomas@monjalon.net>]

28/04/2017 11:13, Olivier Matz:
> Hi Wenzhuo,
> 
> On Fri, 28 Apr 2017 08:38:21 +0000, "Lu, Wenzhuo" <wenzhuo.lu@intel.com> wrote:
> > Hi Oilvier,
> > As we discussed before, I send this patch. Would you like to take a look at it? Better fix it before release 17.05, thanks.
> > 
> > 
> > > When parsing a CLI, all the CLI instances are checked one by one. Even if an
> > > instance already matches the CLI, the parsing will not stop for ambiguous
> > > check.
> > > The problem is that the following check may change the parsing result of the
> > > previous one even if the following instance doesn't match.
> > > 
> > > Use a temporary validate for the parsing result when trying to match an
> > > instance and only store the result when it matches, so the previous result
> > > has no chance to be changed.
> > > 
> > > Fixes: af75078fece3 ("first public release")
> > > CC: stable@dpdk.org
> > > 
> > > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> 
> Sorry for the delay,
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks