From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34731)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1WTVBl-0007hD-Sr
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 07:43:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1WTVBg-0001zb-6l
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 07:43:09 -0400
Received: from omzsmtpe04.verizonbusiness.com ([199.249.25.207]:21592)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1WTVBg-0001zR-1L
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 07:43:04 -0400
From: Don Slutz <dslutz@verizon.com>
Message-ID: <53356044.7020309@terremark.com>
Date: Fri, 28 Mar 2014 07:43:00 -0400
MIME-Version: 1.0
References: <1395160174-16006-1-git-send-email-dslutz@verizon.com>
In-Reply-To: <1395160174-16006-1-git-send-email-dslutz@verizon.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/1] char/serial: Fix emptyness handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Don Slutz <dslutz@verizon.com>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, qemu-devel@nongnu.org

Ping.  (Since this is a bug fix, I think it can go into 2.0)
     -Don Slutz

On 03/18/14 12:29, Don Slutz wrote:
> The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244
> char/serial: Fix emptyness check
>
> Still causes extra NULL byte(s) to be sent.
>
> So if the fifo is empty, do not send an extra NULL byte.
>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> Signed-off-by: Don Slutz <dslutz@verizon.com>
> ---
> Changes V2 to v3
>    Revert v2 changes
>    Fix coding style issues.
> Changes v1 to v2
>    Do full state change on fifo8_is_empty.
>   
>
>   hw/char/serial.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/char/serial.c b/hw/char/serial.c
> index 6d3b5af..f4d167f 100644
> --- a/hw/char/serial.c
> +++ b/hw/char/serial.c
> @@ -225,8 +225,10 @@ static gboolean serial_xmit(GIOChannel *chan, GIOCondition cond, void *opaque)
>   
>       if (s->tsr_retry <= 0) {
>           if (s->fcr & UART_FCR_FE) {
> -            s->tsr = fifo8_is_empty(&s->xmit_fifo) ?
> -                        0 : fifo8_pop(&s->xmit_fifo);
> +            if (fifo8_is_empty(&s->xmit_fifo)) {
> +                return FALSE;
> +            }
> +            s->tsr = fifo8_pop(&s->xmit_fifo);
>               if (!s->xmit_fifo.num) {
>                   s->lsr |= UART_LSR_THRE;
>               }