From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Subject: Re: [PATCH 06/16] drm: Protect the master management with a drm_device::master_mutex v3 Date: Fri, 28 Mar 2014 12:52:14 +0100 Message-ID: <5335626E.6000507@vmware.com> References: <1395999282-12553-1-git-send-email-thellstrom@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-outbound-2.vmware.com (smtp-outbound-2.vmware.com [208.91.2.13]) by gabe.freedesktop.org (Postfix) with ESMTP id B09676EC76 for ; Fri, 28 Mar 2014 04:52:17 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Herrmann Cc: Thomas Hellstrom , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On 03/28/2014 12:23 PM, David Herrmann wrote: > Hi > > On Fri, Mar 28, 2014 at 10:34 AM, Thomas Hellstrom > wrote: >> The master management was previously protected by the drm_device::struct_mutex. >> In order to avoid locking order violations in a reworked dropped master >> security check in the vmwgfx driver, break it out into a separate master_mutex. >> Locking order is master_mutex -> struct_mutex. >> >> Also remove drm_master::blocked since it's not used. >> >> v2: Add an inline comment about what drm_device::master_mutex is protecting. >> v3: Remove unneeded struct_mutex locks. Fix error returns in >> drm_setmaster_ioctl(). > Thanks, looks much better now. Tested on hsw, so I'm fine with pushing > this into 3.15. > > Thanks > David > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel Thanks. Want a Reviewed-By: or Acked-By: added? /Thomas