From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org,
xen-devel@lists.xen.org, David Vrabel <david.vrabel@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] arm: xen: implement multicall hypercall support.
Date: Fri, 28 Mar 2014 14:51:58 +0000 [thread overview]
Message-ID: <53358C8E.9010407@linaro.org> (raw)
In-Reply-To: <1396015660-7834-1-git-send-email-ian.campbell@citrix.com>
Hi Ian,
On 03/28/2014 02:07 PM, Ian Campbell wrote:
> As part of this make the usual change to xen_ulong_t in place of unsigned long.
> This change has no impact on x86.
>
> The Linux defintion of struct multicall_entry.result differs from the Xen
definition
[..]
> diff --git a/arch/arm/include/asm/xen/hypercall.h b/arch/arm/include/asm/xen/hypercall.h
> index 7704e28..7658150 100644
> --- a/arch/arm/include/asm/xen/hypercall.h
> +++ b/arch/arm/include/asm/xen/hypercall.h
> @@ -48,6 +48,7 @@ int HYPERVISOR_memory_op(unsigned int cmd, void *arg);
> int HYPERVISOR_physdev_op(int cmd, void *arg);
> int HYPERVISOR_vcpu_op(int cmd, int vcpuid, void *extra_args);
> int HYPERVISOR_tmem_op(void *arg);
> +int HYPERVISOR_multicall(struct multicall_entry *calls, uint32_t nr);
The x86 prototype of HYPERVISOR_multicall takes an int as 2nd parameter.
I guess we should stay consistent here.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-03-28 14:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 14:07 [PATCH] xen: arm: fully implement multicall interface Ian Campbell
2014-03-28 14:07 ` [PATCH] arm: xen: implement multicall hypercall support Ian Campbell
2014-03-28 14:51 ` Julien Grall [this message]
2014-03-28 14:58 ` Ian Campbell
2014-04-01 11:02 ` David Vrabel
2014-04-01 11:13 ` Ian Campbell
2014-03-28 14:22 ` [PATCH] xen: arm: fully implement multicall interface Julien Grall
2014-03-28 14:37 ` Ian Campbell
2014-03-28 15:03 ` Jan Beulich
2014-04-01 10:01 ` George Dunlap
2014-03-28 14:45 ` Ian Campbell
2014-03-28 15:01 ` Julien Grall
2014-03-28 15:07 ` Ian Campbell
2014-03-31 16:38 ` George Dunlap
2014-04-01 9:05 ` Julien Grall
2014-04-01 9:28 ` Ian Campbell
2014-04-01 10:46 ` Julien Grall
2014-04-01 10:49 ` Ian Campbell
2014-04-01 11:00 ` Julien Grall
2014-04-01 11:15 ` Ian Campbell
2014-04-01 12:05 ` Julien Grall
2014-04-01 12:11 ` Ian Campbell
2014-04-01 12:16 ` Julien Grall
2014-04-01 12:16 ` Ian Campbell
2014-04-01 12:53 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53358C8E.9010407@linaro.org \
--to=julien.grall@linaro.org \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.