From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>,
qemu-devel@nongnu.org, laurent.desnogues@gmail.com
Subject: Re: [Qemu-devel] [PATCH for-2.0] cpu: do not use QOM casts in ENV_GET_CPU
Date: Fri, 28 Mar 2014 15:56:27 +0100 [thread overview]
Message-ID: <53358D9B.5090809@redhat.com> (raw)
In-Reply-To: <53358C9F.2040000@suse.de>
Il 28/03/2014 15:52, Andreas Färber ha scritto:
> I do wonder if it wouldn't make more sense to simply
> #define CPU(obj) ((CPUState *)obj)
> which would catch all uses of CPU() while still allowing to change it to
> #define CPU(obj) dynamic_cast<CPUState>(obj)
> or so in the future without touching dozens of places. We can obviously
> also take this patch here for 2.0 and then revert and redo differently.
I suggest doing a C-cast patch for 2.0, and then possibly revert and
redo differently in 2.1.
prev parent reply other threads:[~2014-03-28 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 13:42 [Qemu-devel] [PATCH for-2.0] cpu: do not use QOM casts in ENV_GET_CPU Paolo Bonzini
2014-03-26 13:55 ` Paolo Bonzini
2014-03-28 14:34 ` Laurent Desnogues
2014-03-28 13:55 ` Laurent Desnogues
2014-03-28 13:59 ` Paolo Bonzini
2014-03-28 14:52 ` Andreas Färber
2014-03-28 14:56 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53358D9B.5090809@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=laurent.desnogues@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.