From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH v3] xen/serial: Don't leak memory mapping if
 the serial initialization has failed
Date: Fri, 28 Mar 2014 15:31:12 +0000
Message-ID: <533595C0.6090606@gmail.com>
References: <1396019517-2778-1-git-send-email-julien.grall@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <keir.xen@gmail.com>) id 1WTYko-0004qy-3p
	for xen-devel@lists.xenproject.org; Fri, 28 Mar 2014 15:31:35 +0000
Received: by mail-we0-f178.google.com with SMTP id u56so2711835wes.37
	for <xen-devel@lists.xenproject.org>;
	Fri, 28 Mar 2014 08:31:15 -0700 (PDT)
In-Reply-To: <1396019517-2778-1-git-send-email-julien.grall@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

Julien Grall wrote:
> The memory mapping leaked when the serial driver failed to retrieve
> the IRQ. We can safely move the call to ioremap after.
>
> Also use ioremap_cache instead of ioremap_attr in some serial drivers.
>
> Signed-off-by: Julien Grall<julien.grall@linaro.org>
> Acked-by: Ian Campbell<ian.campbell@citrix.com>
> Cc: Keir Fraser<keir@xen.org>
Acked-by: Keir Fraser <keir@xen.org>