From: Mark Tinguely <tinguely@sgi.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs: remove efi from AIL in log recovery error
Date: Fri, 28 Mar 2014 11:21:28 -0500 [thread overview]
Message-ID: <5335A188.4060400@sgi.com> (raw)
In-Reply-To: <20140328160719.GA15537@bfoster.bfoster>
On 03/28/14 11:07, Brian Foster wrote:
> On Fri, Mar 28, 2014 at 10:41:06AM -0500, Mark Tinguely wrote:
>> On 03/28/14 10:24, Brian Foster wrote:
>>> On Tue, Mar 25, 2014 at 03:06:34PM -0500, Mark Tinguely wrote:
...
>>> Hi Mark,
>>>
>>> If we hit the scenario where we start skipping EFIs after an error, is
>>> the equivalent unpin() call from process_efi() not necessary on the
>>> subsequent EFIs?
>>>
>>> Brian
>>
>> yes, good catch. They will have to be decremented twice. something like:
>> + if (!error)
>> + error = xlog_recover_process_efi(log->l_mp, efip);
>> + else
>> + xfs_efi_item_unpin(&efip->efi_item, 0);
>> + if (error)
>> ...
>>
>
> Ok, looks reasonable to me. An extra sentence or two in the previous
> comment to explain what's going on there would be nice as well. ;)
>
> Brian
Probably will flip the if statement logic, but a comment is also a good
idea. Thank-you for the feed back.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-03-28 16:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 20:06 [PATCH 0/2] xfs: Clean the EFI on errors series Mark Tinguely
2014-03-25 20:06 ` [PATCH 1/2] xfs: remove efi from AIL in log recovery error Mark Tinguely
2014-03-28 15:24 ` Brian Foster
2014-03-28 15:41 ` Mark Tinguely
2014-03-28 16:07 ` Brian Foster
2014-03-28 16:21 ` Mark Tinguely [this message]
2014-03-31 20:25 ` [PATCH v2 1/2] xfs: remove efi from AIL in log recovery Mark Tinguely
2014-04-03 19:07 ` Dave Chinner
2014-03-25 20:06 ` [PATCH 2/2] xfs: free the EFI entries from AIL on forced shutdown Mark Tinguely
2014-04-03 19:34 ` Dave Chinner
2014-04-03 20:48 ` Mark Tinguely
2014-04-03 21:53 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5335A188.4060400@sgi.com \
--to=tinguely@sgi.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.