From: Stefan Weil <sw@weilnetz.de>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Andreas Faerber <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3 2/3] tests: skip POSIX-only tests on Windows
Date: Fri, 28 Mar 2014 19:21:34 +0100 [thread overview]
Message-ID: <5335BDAE.9010708@weilnetz.de> (raw)
In-Reply-To: <1396000554-29501-3-git-send-email-stefanha@redhat.com>
Am 28.03.2014 10:55, schrieb Stefan Hajnoczi:
> test-rfifolock and test-vmstate only build on POSIX hosts. Exclude them
> if building for Windows.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> tests/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 2d021fb..ef286e7 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -35,7 +35,7 @@ check-unit-y += tests/test-visitor-serialization$(EXESUF)
> check-unit-y += tests/test-iov$(EXESUF)
> gcov-files-test-iov-y = util/iov.c
> check-unit-y += tests/test-aio$(EXESUF)
> -check-unit-y += tests/test-rfifolock$(EXESUF)
> +check-unit-$(CONFIG_POSIX) += tests/test-rfifolock$(EXESUF)
> check-unit-y += tests/test-throttle$(EXESUF)
> gcov-files-test-aio-$(CONFIG_WIN32) = aio-win32.c
> gcov-files-test-aio-$(CONFIG_POSIX) = aio-posix.c
> @@ -59,7 +59,7 @@ check-unit-y += tests/test-bitops$(EXESUF)
> check-unit-y += tests/test-qdev-global-props$(EXESUF)
> check-unit-y += tests/check-qom-interface$(EXESUF)
> gcov-files-check-qom-interface-y = qom/object.c
> -check-unit-y += tests/test-vmstate$(EXESUF)
> +check-unit-$(CONFIG_POSIX) += tests/test-vmstate$(EXESUF)
>
> check-block-$(CONFIG_POSIX) += tests/qemu-iotests-quick.sh
Thanks.
Reviewed-by: Stefan Weil <sw@weilnetz.de>
next prev parent reply other threads:[~2014-03-28 18:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 9:55 [Qemu-devel] [PATCH v3 0/3] tests: mingw32 make check fixes Stefan Hajnoczi
2014-03-28 9:55 ` [Qemu-devel] [PATCH v3 1/3] tests: Remove unsupported tests for MinGW Stefan Hajnoczi
2014-03-28 9:55 ` [Qemu-devel] [PATCH v3 2/3] tests: skip POSIX-only tests on Windows Stefan Hajnoczi
2014-03-28 18:21 ` Stefan Weil [this message]
2014-03-28 9:55 ` [Qemu-devel] [PATCH v3 3/3] tests: correctly skip qtest on non-POSIX hosts Stefan Hajnoczi
2014-03-31 7:26 ` [Qemu-devel] [PATCH v3 0/3] tests: mingw32 make check fixes Stefan Hajnoczi
2014-03-31 8:04 ` Andreas Färber
2014-03-31 20:25 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5335BDAE.9010708@weilnetz.de \
--to=sw@weilnetz.de \
--cc=afaerber@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.