From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56057)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WTbpo-000431-V2
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 14:49:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WTbpi-0004q2-Rd
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 14:48:56 -0400
Received: from mail-qa0-x22b.google.com ([2607:f8b0:400d:c00::22b]:49280)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WTbpi-0004pw-Mv
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 14:48:50 -0400
Received: by mail-qa0-f43.google.com with SMTP id j15so5716154qaq.30
	for <qemu-devel@nongnu.org>; Fri, 28 Mar 2014 11:48:50 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5335C40E.3010102@twiddle.net>
Date: Fri, 28 Mar 2014 11:48:46 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1396020588-2137-1-git-send-email-peter.maydell@linaro.org>
	<5335BA31.1070605@twiddle.net>
	<CAFEAcA97Ek81unhKzJbabCz9K9dN1QaFxpJ7FC6tK78vCg6SqA@mail.gmail.com>
In-Reply-To: <CAFEAcA97Ek81unhKzJbabCz9K9dN1QaFxpJ7FC6tK78vCg6SqA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 0/3] tcg: Avoid undefined behaviour on
	unaligned stores
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>

On 03/28/2014 11:18 AM, Peter Maydell wrote:
> On 28 March 2014 18:06, Richard Henderson <rth@twiddle.net> wrote:
>> On 03/28/2014 08:29 AM, Peter Maydell wrote:
>>> Peter Maydell (3):
>>>   exec-all.h: Use stl_p to avoid undefined behaviour patching x86 jumps
>>>   tcg: Avoid stores to unaligned addresses
>>>   tcg: Avoid undefined behaviour patching code at unaligned addresses
>>
>> Reviewed-by: Richard Henderson <rth@twiddle.net>
> 
> I was expecting more argument :-)
> 
> I'll do a respin with separate tcg_out*_unaligned and tcg_out*,
> and update all the backends.

Please don't.  I'd rather make different changes there, making s->code_ptr be
more appropriate to the elemental type of the native insn.

Since x86 wouldn't change its elemental type, I think your change is the best
of the possible solutions there.


r~