From: Max Reitz <mreitz@redhat.com>
To: Prasad Joshi <prasadjoshi.linux@gmail.com>
Cc: qemu-trivial@nongnu.org, kwolf@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qcow2: fix two memory leaks in qcow2_open error code path
Date: Fri, 28 Mar 2014 23:26:42 +0100 [thread overview]
Message-ID: <5335F722.8060008@redhat.com> (raw)
In-Reply-To: <1396028338-3810-1-git-send-email-prasadjoshi.linux@gmail.com>
On 28.03.2014 18:38, Prasad Joshi wrote:
> Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
> ---
> block/qcow2.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index b9dc960..10eccf9 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -506,6 +506,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags,
> s->incompatible_features &
> ~QCOW2_INCOMPAT_MASK);
> ret = -ENOTSUP;
> + g_free(feature_table);
> goto fail;
> }
>
> @@ -745,6 +746,9 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags,
> if (s->l2_table_cache) {
> qcow2_cache_destroy(bs, s->l2_table_cache);
> }
> + if (s->refcount_block_cache) {
> + qcow2_cache_destroy(bs, s->refcount_block_cache);
> + }
> g_free(s->cluster_cache);
> qemu_vfree(s->cluster_data);
> return ret;
Reviewed-by: Max Reitz <mreitz@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Max Reitz <mreitz@redhat.com>
To: Prasad Joshi <prasadjoshi.linux@gmail.com>
Cc: qemu-trivial@nongnu.org, kwolf@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qcow2: fix two memory leaks in qcow2_open error code path
Date: Fri, 28 Mar 2014 23:26:42 +0100 [thread overview]
Message-ID: <5335F722.8060008@redhat.com> (raw)
In-Reply-To: <1396028338-3810-1-git-send-email-prasadjoshi.linux@gmail.com>
On 28.03.2014 18:38, Prasad Joshi wrote:
> Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
> ---
> block/qcow2.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index b9dc960..10eccf9 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -506,6 +506,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags,
> s->incompatible_features &
> ~QCOW2_INCOMPAT_MASK);
> ret = -ENOTSUP;
> + g_free(feature_table);
> goto fail;
> }
>
> @@ -745,6 +746,9 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags,
> if (s->l2_table_cache) {
> qcow2_cache_destroy(bs, s->l2_table_cache);
> }
> + if (s->refcount_block_cache) {
> + qcow2_cache_destroy(bs, s->refcount_block_cache);
> + }
> g_free(s->cluster_cache);
> qemu_vfree(s->cluster_data);
> return ret;
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-03-29 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 17:38 [Qemu-trivial] [PATCH] qcow2: fix two memory leaks in qcow2_open error code path Prasad Joshi
2014-03-28 17:38 ` [Qemu-devel] " Prasad Joshi
2014-03-28 22:26 ` Max Reitz [this message]
2014-03-28 22:26 ` Max Reitz
2014-03-31 9:03 ` [Qemu-trivial] " Stefan Hajnoczi
2014-03-31 9:03 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5335F722.8060008@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=prasadjoshi.linux@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.