From: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/9] Documentation cleanup
Date: Sat, 29 Mar 2014 10:52:38 +0100 [thread overview]
Message-ID: <533697E6.5000804@trzebnica.net> (raw)
In-Reply-To: <20140329093317.29e80f16@skate>
Hi Thomas,
> Dear Jerzy Grzegorek,
>
> On Fri, 28 Mar 2014 22:24:41 +0100, Jerzy Grzegorek wrote:
>
>> Here is a series that fixes a few typoes and makes small improvements
>> in documentation.
> I've applied patches 1 to 6, 8 and 9. For patch 2, I made the change we
> discussed.
>
> I haven't applied patch 7, because I don't agree with:
>
> +series is introduced by a cover letter, an overall patch version may be
> +added to the cover letter in addition/instead to the individual commits.
>
> The version in the title of the cover letter does *not* replace the
> version in the title of the patches. Both should be present, so the
> "/instead" is not correct. Also, the "may be added" does not seem
> right, because a version is always added to the cover letter title by
> "git format-patch --subject-prefix".
Regarding the "may be added", I agree.
I proposed this change because I saw on mailing list both cases of
submitting patch series introduced by a cover letter:
* "in addition" case:
[Patch vX 0/Y] ...
[Patch vX 1/Y] ...
...
[Patch vX Y/Y] ...
* "instead" case:
[Patch vX 0/Y] ...
[Patch 1/Y] ...
...
[Patch Y/Y] ...
but ok, agree.
So maybe it should be:
"Note that when your patch series is introduced by a cover letter,
a patch version should be added to the cover letter in addition to
the individual commits."
Regards,
Jerzy
>
> Best regards,
>
> Thomas
next prev parent reply other threads:[~2014-03-29 9:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 21:24 [Buildroot] [PATCH 0/9] Documentation cleanup Jerzy Grzegorek
2014-03-28 21:24 ` [Buildroot] [PATCH 1/9] manual/configure.txt: reword part about internal toolchain backend Jerzy Grzegorek
2014-03-28 21:24 ` [Buildroot] [PATCH 2/9] manual/configure.txt: fix typo Jerzy Grzegorek
2014-03-28 21:32 ` Thomas Petazzoni
2014-03-28 23:01 ` Jerzy Grzegorek
2014-03-28 21:24 ` [Buildroot] [PATCH 3/9] manual/make-tips.txt: " Jerzy Grzegorek
2014-03-28 21:24 ` [Buildroot] [PATCH 4/9] manual/contribute.txt: " Jerzy Grzegorek
2014-03-28 21:24 ` [Buildroot] [PATCH 5/9] manual/contribute.txt: reword part about reporting issues Jerzy Grzegorek
2014-03-28 21:24 ` [Buildroot] [PATCH 6/9] manual/legal-notice.txt: fix typo Jerzy Grzegorek
2014-03-28 21:24 ` [Buildroot] [PATCH 7/9] manual/contribute.txt: reword part about versioning patches Jerzy Grzegorek
2014-03-28 21:24 ` [Buildroot] [PATCH 8/9] manual: fix typo in abbreviation 'e.g.' Jerzy Grzegorek
2014-03-28 21:24 ` [Buildroot] [PATCH 9/9] manual: fix typo in abbreviation 'i.e.' Jerzy Grzegorek
2014-03-29 8:33 ` [Buildroot] [PATCH 0/9] Documentation cleanup Thomas Petazzoni
2014-03-29 9:52 ` Jerzy Grzegorek [this message]
2014-03-29 10:28 ` Thomas Petazzoni
2014-03-29 10:59 ` Jerzy Grzegorek
2014-03-29 11:05 ` Thomas Petazzoni
2014-03-29 11:17 ` Yann E. MORIN
2014-03-29 11:36 ` Thomas Petazzoni
2014-03-29 11:46 ` Jerzy Grzegorek
2014-03-29 13:28 ` Thomas Petazzoni
2014-03-30 21:52 ` Jerzy Grzegorek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533697E6.5000804@trzebnica.net \
--to=jerzy.grzegorek@trzebnica.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.