From: b.brezillon.dev@gmail.com (Boris BREZILLON)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 03/10] ARM: at91: introduce OLD_IRQ_AT91 Kconfig option
Date: Sat, 29 Mar 2014 10:52:56 +0100 [thread overview]
Message-ID: <533697F8.5000903@gmail.com> (raw)
In-Reply-To: <7407417.cSDunZuEhW@wuerfel>
Le 29/03/2014 10:12, Arnd Bergmann a ?crit :
> On Saturday 29 March 2014 10:06:39 Thomas Petazzoni wrote:
>> Dear Boris BREZILLON,
>>
>> On Fri, 28 Mar 2014 18:59:01 +0100, Boris BREZILLON wrote:
>>
>>> +config OLD_IRQ_AT91
>>> + bool
>>> + default false
>> I don't think "default false" is a valid Kconfig construct. It could be
>> "default n", but that's useless since "default n" is the default
>> behavior. So I believe you can simply get rid of that line.
I'll fix it for the next version.
> I think the above is syntactically correct, but it would be highly confusing in
> anyone ever does
>
> config false
> def_bool y
>
> ;-)
>
> Aside from that, these three have completely identical meaning:
>
> config OLD_IRQ_AT91
> bool
>
> config OLD_IRQ_AT91
> def_bool n
>
> config OLD_IRQ_AT91
> bool
> default n
>
> Arnd
>
>
Thanks for the detailled explanation :-).
Best Regards,
Boris
WARNING: multiple messages have this Message-ID (diff)
From: Boris BREZILLON <b.brezillon.dev@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org, Rob Landley <rob@landley.net>,
Thomas Gleixner <tglx@linutronix.de>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [RFC PATCH v2 03/10] ARM: at91: introduce OLD_IRQ_AT91 Kconfig option
Date: Sat, 29 Mar 2014 10:52:56 +0100 [thread overview]
Message-ID: <533697F8.5000903@gmail.com> (raw)
In-Reply-To: <7407417.cSDunZuEhW@wuerfel>
Le 29/03/2014 10:12, Arnd Bergmann a écrit :
> On Saturday 29 March 2014 10:06:39 Thomas Petazzoni wrote:
>> Dear Boris BREZILLON,
>>
>> On Fri, 28 Mar 2014 18:59:01 +0100, Boris BREZILLON wrote:
>>
>>> +config OLD_IRQ_AT91
>>> + bool
>>> + default false
>> I don't think "default false" is a valid Kconfig construct. It could be
>> "default n", but that's useless since "default n" is the default
>> behavior. So I believe you can simply get rid of that line.
I'll fix it for the next version.
> I think the above is syntactically correct, but it would be highly confusing in
> anyone ever does
>
> config false
> def_bool y
>
> ;-)
>
> Aside from that, these three have completely identical meaning:
>
> config OLD_IRQ_AT91
> bool
>
> config OLD_IRQ_AT91
> def_bool n
>
> config OLD_IRQ_AT91
> bool
> default n
>
> Arnd
>
>
Thanks for the detailled explanation :-).
Best Regards,
Boris
next prev parent reply other threads:[~2014-03-29 9:52 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 17:58 [RFC PATCH v2 00/10] ARM: at91: move aic driver to drivers/irqchips Boris BREZILLON
2014-03-28 17:58 ` Boris BREZILLON
2014-03-28 17:58 ` Boris BREZILLON
2014-03-28 17:58 ` [RFC PATCH v2 01/10] genirq: generic chip: export irq_map_generic_chip function Boris BREZILLON
2014-03-28 17:58 ` Boris BREZILLON
2014-03-28 17:59 ` [RFC PATCH v2 02/10] irqchip: atmel-aic: add new atmel AIC driver Boris BREZILLON
2014-03-28 17:59 ` Boris BREZILLON
2014-03-28 17:59 ` [RFC PATCH v2 03/10] ARM: at91: introduce OLD_IRQ_AT91 Kconfig option Boris BREZILLON
2014-03-28 17:59 ` Boris BREZILLON
2014-03-29 9:06 ` Thomas Petazzoni
2014-03-29 9:06 ` Thomas Petazzoni
2014-03-29 9:06 ` Thomas Petazzoni
2014-03-29 9:12 ` Arnd Bergmann
2014-03-29 9:12 ` Arnd Bergmann
2014-03-29 9:52 ` Boris BREZILLON [this message]
2014-03-29 9:52 ` Boris BREZILLON
2014-03-28 17:59 ` [RFC PATCH v2 04/10] ARM: at91: enclose at91_aic_xx calls in IS_ENABLED(CONFIG_OLD_IRQ_AT91) blocks Boris BREZILLON
2014-03-28 17:59 ` Boris BREZILLON
2014-03-28 17:59 ` [RFC PATCH v2 05/10] ARM: at91: make use of the new AIC driver for dt enabled boards Boris BREZILLON
2014-03-28 17:59 ` Boris BREZILLON
2014-03-28 17:59 ` Boris BREZILLON
2014-03-29 9:07 ` Thomas Petazzoni
2014-03-29 9:07 ` Thomas Petazzoni
2014-03-29 10:11 ` Boris BREZILLON
2014-03-29 10:11 ` Boris BREZILLON
2014-03-29 10:11 ` Boris BREZILLON
2014-03-28 17:59 ` [RFC PATCH v2 06/10] irqchip: atmel-aic: move binding doc to interrupt-controller directory Boris BREZILLON
2014-03-28 17:59 ` Boris BREZILLON
2014-03-28 17:59 ` Boris BREZILLON
2014-03-28 17:59 ` [RFC PATCH v2 07/10] irqchip: atmel-aic: document new dt properties and children nodes Boris BREZILLON
2014-03-28 17:59 ` Boris BREZILLON
2014-03-29 9:19 ` Thomas Petazzoni
2014-03-29 9:19 ` Thomas Petazzoni
2014-03-29 9:19 ` Thomas Petazzoni
2014-03-30 13:27 ` Boris BREZILLON
2014-03-30 13:27 ` Boris BREZILLON
2014-03-30 14:55 ` Boris BREZILLON
2014-03-28 17:59 ` [RFC PATCH v2 08/10] ARM: at91: remove old irq material Boris BREZILLON
2014-03-28 17:59 ` Boris BREZILLON
2014-03-28 17:59 ` [RFC PATCH v2 09/10] ARM: at91/dt: add new AIC irq mux definitions for sam9x5 SoCs Boris BREZILLON
2014-03-28 17:59 ` Boris BREZILLON
2014-03-28 17:59 ` [RFC PATCH v2 10/10] ARM: at91/dt: add new AIC irq mux definitions for sama5 SoCs Boris BREZILLON
2014-03-28 17:59 ` Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533697F8.5000903@gmail.com \
--to=b.brezillon.dev@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.