From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 0/8] tcg: tidy the type of code_ptr
Date: Sun, 30 Mar 2014 08:31:20 -0700 [thread overview]
Message-ID: <533838C8.80307@twiddle.net> (raw)
In-Reply-To: <CAFEAcA_dK5N7QACUb02BHhwz=Bsf5bsfzZrt+cavFEUuB0Gi8w@mail.gmail.com>
On 03/29/2014 01:26 PM, Peter Maydell wrote:
> It seems like it might be worth abstracting out "give me the byte
> difference between these two code pointers" rather than having
> inline (uintptr_t)codeptr1 - (uintptr_t)codeptr2, but I dunno.
Yeah, I dithered about that. I couldn't come up with a good name that
adequately described what I wanted that was really any shorter than just having
the casts.
> Is there a better name than 'tcg_itype' ? Putting 'type' in the
> name of a type is a bit redundant, and suggests it contains
> a type rather than an insn.
I'm open to suggestions there as well. On x86 and ia64, it won't hold an
entire insn, so "tcg_insn" seemed inappropriate.
r~
next prev parent reply other threads:[~2014-03-30 15:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-29 0:27 [Qemu-devel] [PATCH 0/8] tcg: tidy the type of code_ptr Richard Henderson
2014-03-29 0:27 ` [Qemu-devel] [PATCH 1/8] exec-all.h: Use stl_p to avoid undefined behaviour patching x86 jumps Richard Henderson
2014-04-01 12:09 ` [Qemu-devel] [PATCH 1/8] exec-all.h: Use stl_p to avoid undefinedbehaviour patching x86 jumpss Alex Bennée
2014-04-01 12:18 ` Peter Maydell
2014-03-29 0:27 ` [Qemu-devel] [PATCH 2/8] tcg: Avoid stores to unaligned addresses Richard Henderson
2014-04-01 12:12 ` Alex Bennée
2014-03-29 0:27 ` [Qemu-devel] [PATCH 3/8] tcg: Avoid undefined behaviour patching code at " Richard Henderson
2014-04-01 12:13 ` [Qemu-devel] [PATCH 3/8] tcg: Avoid undefined behaviour patchingcode at unaligned addressess Alex Bennée
2014-03-29 0:27 ` [Qemu-devel] [PATCH 4/8] tcg: Define tcg_itype for code pointers Richard Henderson
2014-03-29 0:27 ` [Qemu-devel] [PATCH 5/8] tcg-ppc64: Define TCG_TARGET_ITYPE_SIZE Richard Henderson
2014-03-29 0:27 ` [Qemu-devel] [PATCH 6/8] tcg-ppc: " Richard Henderson
2014-03-29 0:27 ` [Qemu-devel] [PATCH 7/8] tcg-aarch64: " Richard Henderson
2014-03-29 0:27 ` [Qemu-devel] [PATCH 8/8] tcg-sparc: " Richard Henderson
2014-03-29 20:26 ` [Qemu-devel] [PATCH 0/8] tcg: tidy the type of code_ptr Peter Maydell
2014-03-30 15:31 ` Richard Henderson [this message]
2014-03-31 3:19 ` Richard Henderson
2014-04-01 12:05 ` Alex Bennée
2014-04-01 12:19 ` Alex Bennée
-- strict thread matches above, loose matches on Subject: below --
2014-03-31 8:25 Jay Foad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533838C8.80307@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.