From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>,
linux-sh@vger.kernel.org, linux-usb@vger.kernel.org
Cc: linux-kernel@lists.codethink.co.uk, magnus.damn@opensource.se,
horms@verge.net.au, devicetree@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH 8/9] ARM: shmobile: lager.dts: add usbphy reference
Date: Sun, 30 Mar 2014 19:28:12 +0000 [thread overview]
Message-ID: <5338704C.2030501@cogentembedded.com> (raw)
In-Reply-To: <1394128887-4197-9-git-send-email-ben.dooks@codethink.co.uk>
Hello.
On 03/06/2014 09:01 PM, Ben Dooks wrote:
> Enable the usbphy node so that the phy driver is available.
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> Reviewed-by: Ian Molton <ian.molton@codethink.co.uk>
> ---
> Cc: linux-sh@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Simon Horman <horms@verge.net.au>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index fd6851f..63d58d6 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -246,3 +246,7 @@
> pinctrl-0 = <&usb2_pins>;
> pinctrl-names = "default";
> };
> +
> +&usbphy {
> + status = "okay";
> +};
I don't see why we need this patch. Why not make USB PHY always enabled?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>,
linux-sh@vger.kernel.org, linux-usb@vger.kernel.org
Cc: linux-kernel@lists.codethink.co.uk, magnus.damn@opensource.se,
horms@verge.net.au, devicetree@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH 8/9] ARM: shmobile: lager.dts: add usbphy reference
Date: Sun, 30 Mar 2014 23:28:12 +0400 [thread overview]
Message-ID: <5338704C.2030501@cogentembedded.com> (raw)
In-Reply-To: <1394128887-4197-9-git-send-email-ben.dooks@codethink.co.uk>
Hello.
On 03/06/2014 09:01 PM, Ben Dooks wrote:
> Enable the usbphy node so that the phy driver is available.
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> Reviewed-by: Ian Molton <ian.molton@codethink.co.uk>
> ---
> Cc: linux-sh@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Simon Horman <horms@verge.net.au>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index fd6851f..63d58d6 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -246,3 +246,7 @@
> pinctrl-0 = <&usb2_pins>;
> pinctrl-names = "default";
> };
> +
> +&usbphy {
> + status = "okay";
> +};
I don't see why we need this patch. Why not make USB PHY always enabled?
WBR, Sergei
next prev parent reply other threads:[~2014-03-30 19:28 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 18:01 Renesas RCar device-tree USB series Ben Dooks
2014-03-06 18:01 ` [PATCH 1/9] pci-rcar-gen2: add devicetree support Ben Dooks
2014-03-06 18:01 ` Ben Dooks
2014-03-06 18:01 ` Ben Dooks
2014-03-06 18:21 ` Ben Dooks
2014-03-30 19:10 ` Sergei Shtylyov
2014-03-30 19:10 ` Sergei Shtylyov
2014-03-30 19:10 ` Sergei Shtylyov
2014-03-30 19:21 ` Ben Dooks
2014-03-30 19:21 ` Ben Dooks
2014-03-30 19:26 ` Sergei Shtylyov
2014-03-30 19:26 ` Sergei Shtylyov
2014-03-30 19:40 ` Ben Dooks
2014-03-30 19:40 ` Ben Dooks
2014-03-30 20:10 ` Sergei Shtylyov
2014-03-30 20:10 ` Sergei Shtylyov
2014-03-31 21:23 ` Sergei Shtylyov
2014-03-31 21:23 ` Sergei Shtylyov
2014-03-30 20:28 ` Sergei Shtylyov
2014-03-30 20:28 ` Sergei Shtylyov
2014-04-04 17:09 ` Bjorn Helgaas
2014-04-04 17:09 ` Bjorn Helgaas
2014-04-04 17:44 ` Ben Dooks
2014-04-04 17:44 ` Ben Dooks
2014-04-04 17:44 ` Ben Dooks
2014-04-04 17:46 ` Sergei Shtylyov
2014-04-04 17:46 ` Sergei Shtylyov
2014-03-06 18:01 ` [PATCH 3/9] phy-rcar-usb-gen2: add device tree support Ben Dooks
2014-03-06 18:01 ` Ben Dooks
2014-03-06 18:16 ` Sergei Shtylyov
2014-03-06 19:16 ` Sergei Shtylyov
2014-03-06 18:19 ` Ben Dooks
2014-03-06 19:54 ` Sergei Shtylyov
2014-03-06 20:54 ` Sergei Shtylyov
2014-03-06 18:01 ` [PATCH 5/9] ARM: shmbobile: r8a7790.dtsi: add pci0/1/2 nodes Ben Dooks
2014-03-06 18:01 ` Ben Dooks
2014-03-31 22:18 ` Sergei Shtylyov
2014-03-31 22:18 ` Sergei Shtylyov
[not found] ` <1394128887-4197-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-03-06 18:01 ` [PATCH 6/9] ARM: shmobile: lager.dts: add pci 0/1/2 Ben Dooks
2014-03-06 18:01 ` Ben Dooks
2014-03-06 18:01 ` [PATCH 7/9] ARM: shmobile: r8a7790.dtsi: add usbphy node Ben Dooks
2014-03-06 18:01 ` Ben Dooks
2014-03-06 18:01 ` [PATCH 8/9] ARM: shmobile: lager.dts: add usbphy reference Ben Dooks
2014-03-06 18:01 ` Ben Dooks
2014-03-30 19:28 ` Sergei Shtylyov [this message]
2014-03-30 19:28 ` Sergei Shtylyov
[not found] ` <5338704C.2030501-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-03-30 19:51 ` Ben Dooks
2014-03-30 19:51 ` Ben Dooks
2014-03-07 5:36 ` Renesas RCar device-tree USB series Magnus Damm
2014-03-07 14:30 ` Ben Dooks
2014-03-07 16:30 ` Sergei Shtylyov
2014-03-07 16:32 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5338704C.2030501@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ben.dooks@codethink.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=magnus.damn@opensource.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.