Re: [PATCH 9/9] ARM: shmobile: lager.dts: link usb-phy to pci nodes

[Ben Dooks <ben.dooks@codethink.co.uk>]

On 30/03/14 20:29, Sergei Shtylyov wrote:
> Hello.
>
> On 03/06/2014 09:01 PM, Ben Dooks wrote:
>
>> Add the necessary links to add the USB phy nodes to the PCI devices
>> that are behind the bridges specified.
>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>>   arch/arm/boot/dts/r8a7790-lager.dts | 37
>> +++++++++++++++++++++++++++++++++++++
>>   1 file changed, 37 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
>> b/arch/arm/boot/dts/r8a7790-lager.dts
>> index 63d58d6..62f486e 100644
>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>> @@ -233,18 +233,55 @@
>>   &pci0 {
>>       pinctrl-0 = <&usb0_pins>;
>>       pinctrl-names = "default";
>> +    device_type = "pci";
>> +
>> +    pci@0,1 {
>> +        reg = <0x800 0 0 0 0>;
>> +        device_type = "pci";
>> +        usb-phy = <&usbphy>;
>> +    };
>> +
>> +    pci@0,2 {
>> +        reg = <0x1000 0 0 0 0>;
>> +        device_type = "pci";
>> +        usb-phy = <&usbphy>;
>> +    };
>>   };
>>
>>   &pci1 {
>>       status = "okay";
>>       pinctrl-0 = <&usb1_pins>;
>>       pinctrl-names = "default";
>> +
>> +    pci@0,1 {
>> +        reg = <0x800 0 0 0 0>;
>> +        device_type = "pci";
>> +        usb-phy = <&usbphy>;
>> +    };
>> +
>> +    pci@0,2 {
>> +        reg = <0x1000 0 0 0 0>;
>> +        device_type = "pci";
>> +        usb-phy = <&usbphy>;
>> +    };
>>   };
>>
>>   &pci2 {
>>       status = "okay";
>>       pinctrl-0 = <&usb2_pins>;
>>       pinctrl-names = "default";
>> +
>> +    pci@0,1 {
>> +        reg = <0x800 0 0 0 0>;
>> +        device_type = "pci";
>> +        usb-phy = <&usbphy>;
>> +    };
>> +
>> +    pci@0,2 {
>> +        reg = <0x1000 0 0 0 0>;
>> +        device_type = "pci";
>> +        usb-phy = <&usbphy>;
>> +    };
>>   };
>
>     I don't see why the internal PCI devices are added to the board
> file, not the SoC file.

Thanks, I think they probably do belong in the .dtsi file.


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius