From: Daniel Borkmann <dborkman@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, brouer@redhat.com
Subject: Re: [PATCH net-next] packet: respect devices with LLTX flag in direct xmit
Date: Sun, 30 Mar 2014 23:52:04 +0200 [thread overview]
Message-ID: <53389204.2010205@redhat.com> (raw)
In-Reply-To: <1396105350.21428.6.camel@edumazet-glaptop2.roam.corp.google.com>
On 03/29/2014 04:02 PM, Eric Dumazet wrote:
> On Fri, 2014-03-28 at 22:13 +0100, Daniel Borkmann wrote:
>> On 03/28/2014 09:50 PM, David Miller wrote:
>
>>> The only remaining issue is that Eric seems to suggest that a tx
>>> dropped counter bump should be added. Please submit that as a
>>> follow-on if my reading of his feedback is accurate.
>>
>> Yes, will do next week. I think at time of submission we didn't
>> have that yet. :)
>
> BTW, how direct xmit performs in case of BQL enabled driver ?
>
> dummy is nice, but not really representative of real device ;)
>
> netif_xmit_frozen_or_stopped() tests (dev_queue->state &
> QUEUE_STATE_ANY_XOFF_OR_FROZEN), so will not fill TX ring.
>
> Since you have no queue, I would rather use a test without
> BQL bit (1 << __QUEUE_STATE_STACK_XOFF), so that you can absorb bursts
> into TX ring ...
Thanks Eric, I'll look into it on next Tuesday [I was on travel
whole weekend and will be on Monday].
prev parent reply other threads:[~2014-03-30 21:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 15:38 [PATCH net-next] packet: respect devices with LLTX flag in direct xmit Daniel Borkmann
2014-03-27 16:01 ` Eric Dumazet
2014-03-27 16:04 ` Eric Dumazet
2014-03-28 20:50 ` David Miller
2014-03-28 21:13 ` Daniel Borkmann
2014-03-29 15:02 ` Eric Dumazet
2014-03-30 21:52 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53389204.2010205@redhat.com \
--to=dborkman@redhat.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.