All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wengang <wen.gang.wang@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [patch 2/8] ocfs2: flock: drop cross-node lock when failed locally
Date: Mon, 31 Mar 2014 09:39:44 +0800	[thread overview]
Message-ID: <5338C760.4090409@oracle.com> (raw)
In-Reply-To: <20140331013047.GC4488@wotan.suse.de>

Hi Mark,

I find it by code review.

thanks,
wengang

? 2014?03?31? 09:30, Mark Fasheh ??:
> On Wed, Mar 19, 2014 at 02:10:00PM -0700, Andrew Morton wrote:
>> From: Wengang Wang <wen.gang.wang@oracle.com>
>> Subject: ocfs2: flock: drop cross-node lock when failed locally
>>
>> ocfs2_do_flock() calls ocfs2_file_lock() to get the cross-node clock and
>> then call flock_lock_file_wait() to compete with local processes.  In case
>> flock_lock_file_wait() failed, say -ENOMEM, clean up work is not done.
>> This patch adds the cleanup --drop the cross-node lock which was just
>> granted.
> Out of curiousity was this a bug someone hit, or did you catch this
> via code review.
>
> Reviewed-by: Mark Fasheh <mfasheh@suse.de>
> 	--Mark
>
> --
> Mark Fasheh
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel

      reply	other threads:[~2014-03-31  1:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19 21:10 [Ocfs2-devel] [patch 2/8] ocfs2: flock: drop cross-node lock when failed locally akpm at linux-foundation.org
2014-03-31  1:30 ` Mark Fasheh
2014-03-31  1:39   ` Wengang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5338C760.4090409@oracle.com \
    --to=wen.gang.wang@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.