Re: [PATCH 4/4] iio:adc:spear_adc move out of staging

[Stefan Roese <sr@denx.de>]

On 30.03.2014 21:42, Jonathan Cameron wrote:
> On 16/03/14 00:25, Hartmut Knaack wrote:
>> Jonathan Cameron schrieb:
>>> This simple driver is ready to move out of staging.
>>>
>>> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
>>> Acked-by: Stefan Roese <sr@denx.de>
> Stefan, there are some 'what is going on?' questions in here you might
> want to answer!

I'll give it a try.

>>> ---
>>>   drivers/iio/adc/Kconfig             |   8 +
>>>   drivers/iio/adc/Makefile            |   1 +
>>>   drivers/iio/adc/spear_adc.c         | 405
>>> ++++++++++++++++++++++++++++++++++++
>>>   drivers/staging/iio/adc/Kconfig     |   8 -
>>>   drivers/staging/iio/adc/Makefile    |   1 -
>>>   drivers/staging/iio/adc/spear_adc.c | 405
>>> ------------------------------------
>>>   6 files changed, 414 insertions(+), 414 deletions(-)
>>>
>>> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
>>> index 5553206..2e3e1b0 100644
>>> --- a/drivers/iio/adc/Kconfig
>>> +++ b/drivers/iio/adc/Kconfig
>>> @@ -164,6 +164,14 @@ config NAU7802
>>>         To compile this driver as a module, choose M here: the
> s>>         module will be called nau7802.
>>>
>>> +config SPEAR_ADC
>>> +    tristate "ST SPEAr ADC"
>>> +    depends on PLAT_SPEAR || COMPILE_TEST
>>> +    depends on HAS_IOMEM
>>> +    help
>>> +      Say yes here to build support for the integrated ADC inside the
>>> +      ST SPEAr SoC. Provides direct access via sysfs.
>>> +
>>>   config TI_ADC081C
>>>       tristate "Texas Instruments ADC081C021/027"
>>>       depends on I2C
>>> diff --git a/drivers/iio/adc/Makefile b/drivers/iio/adc/Makefile
>>> index 89f1216..8378fb2 100644
>>> --- a/drivers/iio/adc/Makefile
>>> +++ b/drivers/iio/adc/Makefile
>>> @@ -18,6 +18,7 @@ obj-$(CONFIG_MAX1363) += max1363.o
>>>   obj-$(CONFIG_MCP320X) += mcp320x.o
>>>   obj-$(CONFIG_MCP3422) += mcp3422.o
>>>   obj-$(CONFIG_NAU7802) += nau7802.o
>>> +obj-$(CONFIG_SPEAR_ADC) += spear_adc.o
>>>   obj-$(CONFIG_TI_ADC081C) += ti-adc081c.o
>>>   obj-$(CONFIG_TI_AM335X_ADC) += ti_am335x_adc.o
>>>   obj-$(CONFIG_TWL6030_GPADC) += twl6030-gpadc.o
>>> diff --git a/drivers/iio/adc/spear_adc.c b/drivers/iio/adc/spear_adc.c
>>> new file mode 100644
>>> index 0000000..18a0a40
>>> --- /dev/null
>>> +++ b/drivers/iio/adc/spear_adc.c
>>> @@ -0,0 +1,405 @@
>>> +/*
>>> + * ST SPEAr ADC driver
>>> + *
>>> + * Copyright 2012 Stefan Roese <sr@denx.de>
>> I found a datasheet at
>> http://www.st.com/st-web-ui/static/active/en/resource/technical/document/reference_manual/DM00034813.pdf
>>
>
> THis is one of a number I think.. Not sure which parts will work out of
> the box
> with this driver though...  Stefan?  What was it written against?

I wrote and tested this driver for the SPEAr600 in 2011/2012. The manual 
mentioned above didn't exist at that time. I used one called 
"UM510_rev3.0.pdf" from Feb 2011. If interested I can send you the 
manual I used at that time.

I don't have access to the SPEAr600 hardware anymore. I'm afraid but I 
can't be of much help here.

Thanks,
Stefan