From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34007)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WUXIP-0000jg-Po
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 04:10:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WUXIJ-0005bf-S3
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 04:10:17 -0400
Received: from cantor2.suse.de ([195.135.220.15]:33674 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WUXIJ-0005Zn-Lz
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 04:10:11 -0400
Message-ID: <533922E1.6000106@suse.de>
Date: Mon, 31 Mar 2014 10:10:09 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1390494179-17332-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1390494179-17332-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] tests/Makefile: Run qom-test for every
	architecture
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, patches@linaro.org

Peter,

Am 23.01.2014 17:22, schrieb Peter Maydell:
> Rather than requiring every new architecture to remember to add a line
> to the Makefile to say that qom-test will work on it, autogenerate
> the list of supported architectures by looking at the files in
> default-configs (as configure does), and add qom-test to the
> test list for all of them automatically.
>=20
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Together with Markus' patch for running the test for all known
> machines for the architecture, this will avoid the problem of
> coverage being missed because of forgetting to update a whitelist.
>=20
>  tests/Makefile | 31 ++++++++-----------------------
>  1 file changed, 8 insertions(+), 23 deletions(-)
>=20
> diff --git a/tests/Makefile b/tests/Makefile
> index fd36eee..42a52ff 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -1,5 +1,9 @@
>  export SRC_PATH
> =20
> +# Get the list of all supported sysemu targets
> +SYSEMU_TARGET_LIST :=3D $(subst -softmmu.mak,,$(notdir \
> +   $(wildcard $(SRC_PATH)/default-configs/*-softmmu.mak)))
> +
>  check-unit-y =3D tests/check-qdict$(EXESUF)
>  gcov-files-check-qdict-y =3D qobject/qdict.c
>  check-unit-y +=3D tests/check-qfloat$(EXESUF)
> @@ -71,7 +75,6 @@ check-qtest-i386-y +=3D tests/acpi-test$(EXESUF)
>  check-qtest-i386-y +=3D tests/rtc-test$(EXESUF)
>  check-qtest-i386-y +=3D tests/i440fx-test$(EXESUF)
>  check-qtest-i386-y +=3D tests/fw_cfg-test$(EXESUF)
> -check-qtest-i386-y +=3D tests/qom-test$(EXESUF)
>  check-qtest-i386-y +=3D tests/blockdev-test$(EXESUF)
>  check-qtest-i386-y +=3D tests/qdev-monitor-test$(EXESUF)
>  check-qtest-x86_64-y =3D $(check-qtest-i386-y)

qom-test gets executed twice for x86_64 now.

Without having debugged this further yet, my guess is this last line is
causing qom-test to get added twice to check-qtest-x86_64-y, once
inherited from check-qtest-i386-y and then newly added like for any
other target. Could you please take a look how to fix?

Thanks,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg