All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen.5i5j@gmail.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	gxt@mprc.pku.edu.cn
Subject: [PATCH] fs/ext4/extents_status.c: fix 64-bit number truncation bug
Date: Mon, 31 Mar 2014 21:16:49 +0800	[thread overview]
Message-ID: <53396AC1.10108@gmail.com> (raw)

'0x7FDEADBEEF' will be truncated to 32-bit number under unicore32. Need
append 'ULL' for it.

The related warning (with allmodconfig under unicore32):

    CC [M]  fs/ext4/extents_status.o
  fs/ext4/extents_status.c: In function ‘__es_remove_extent’:
  fs/ext4/extents_status.c:813: warning: integer constant is too large for ‘long’ type


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 fs/ext4/extents_status.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
index 0a014a7..0ebc212 100644
--- a/fs/ext4/extents_status.c
+++ b/fs/ext4/extents_status.c
@@ -810,7 +810,7 @@ retry:
 
 			newes.es_lblk = end + 1;
 			newes.es_len = len2;
-			block = 0x7FDEADBEEF;
+			block = 0x7FDEADBEEFULL;
 			if (ext4_es_is_written(&orig_es) ||
 			    ext4_es_is_unwritten(&orig_es))
 				block = ext4_es_pblock(&orig_es) +
-- 
1.7.9.5

             reply	other threads:[~2014-03-31 13:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31 13:16 Chen Gang [this message]
2014-04-04  9:18 ` [PATCH] fs/ext4/extents_status.c: fix 64-bit number truncation bug Chen Gang
2014-04-04  9:18   ` Chen Gang
2014-04-06 13:39 ` Geert Uytterhoeven
2014-04-06 23:58   ` Chen Gang
2014-04-06 23:58     ` Chen Gang
2014-04-07  4:14   ` Theodore Ts'o
2014-04-07  4:14     ` Theodore Ts'o
2014-04-07  5:00     ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53396AC1.10108@gmail.com \
    --to=gang.chen.5i5j@gmail.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.