From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 2/2] x86/HVM: Use fixed TSC value when
 saving or restoring domain
Date: Mon, 31 Mar 2014 10:01:20 -0400
Message-ID: <53397530.8060007@oracle.com>
References: <1396148751-6918-1-git-send-email-boris.ostrovsky@oracle.com>
	<1396148751-6918-3-git-send-email-boris.ostrovsky@oracle.com>
	<533956C50200007800003B02@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <533956C50200007800003B02@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, eddie.dong@intel.com, xen-devel@lists.xen.org, jun.nakajima@intel.com, suravee.suthikulpanit@amd.com
List-Id: xen-devel@lists.xenproject.org

On 03/31/2014 05:51 AM, Jan Beulich wrote:
>
>> --- a/xen/arch/x86/hvm/save.c
>> +++ b/xen/arch/x86/hvm/save.c
>> @@ -24,7 +24,7 @@
>>   #include <asm/hvm/support.h>
>>   #include <public/hvm/save.h>
>>   
>> -void arch_hvm_save(struct domain *d, struct hvm_save_header *hdr)
>> +void arch_hvm_save(struct domain *dom, struct hvm_save_header *hdr)
> The change is unmotivated (afaict) and inconsistent with most other
> code - we conventionally use "d" for struct domain * variables. Please
> drop the change here and use "d" throughout the rest of the patch,
> at once resulting in less churn and hence making it easier to review.

The reason for this change is subsequent
     rdtscll(dom->arch.chkpt_tsc);

which will not work as
     rdtscll(d->arch.chkpt_tsc);

The alternatives as I see are
* Declare a temporary variable for use with rdtscll
* Change rdtscll's definition to use something else instead of variable 
'd'. Say, eax and edx (hopefully this won't clash with something else)


>
>> index 95b4b91..032eb23 100644
>> --- a/xen/include/xen/time.h
>> +++ b/xen/include/xen/time.h
>> @@ -32,7 +32,8 @@ struct vcpu;
>>   typedef s64 s_time_t;
>>   #define PRI_stime PRId64
>>   
>> -s_time_t get_s_time(void);
>> +s_time_t get_s_time_fixed(u64 at_tick);
>> +#define get_s_time() get_s_time_fixed(0)
> get_s_time(), through NOW(), has quite many users, so I'm not certain
> the code bloat resulting from this is desirable. I'd suggest the function
> to remain such; the compiler will be able to make it a mov+jmp.

Sorry, not sure I understand what you are asking for.

There shouldn't be much of code size increase since get_s_time() 
currently (and get_s_time_fixed() after this patch is applied) are not 
inlines. The only increase is due to routine itself getting very 
slightly larger.

But I suspect you meant something else.

-boris