From: Stephen Warren <swarren@wwwdotorg.org>
To: Mark Brown <broonie@kernel.org>
Cc: Oder Chiou <oder_chiou@realtek.com>,
bardliao@realtek.com, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, flove@realtek.com
Subject: Re: [PATCH] ASoC: rt5640: Use the platform data for DMIC settings
Date: Mon, 31 Mar 2014 09:45:01 -0600 [thread overview]
Message-ID: <53398D7D.3010507@wwwdotorg.org> (raw)
In-Reply-To: <20140328234659.GA21628@sirena.org.uk>
On 03/28/2014 05:46 PM, Mark Brown wrote:
> On Fri, Mar 28, 2014 at 10:05:49AM -0600, Stephen Warren wrote:
>> On 03/27/2014 08:46 PM, Oder Chiou wrote:
>
>>> The patch uses the platform data for DMIC settings.
>
>> Shouldn't this also support parsing the same information from device tree?
>
> The driver has no DT support at all at the minute but if it's being used
> on platforms using DT (which of course it is now I think about it - I
> just looked for the DT support when reviewing) then yes it should.
The driver doesn't have an OF match table (I'll send a patch to fix that
soon), but certainly does support DT; see rt5640_parse_dt().
next prev parent reply other threads:[~2014-03-31 15:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 2:46 [PATCH] ASoC: rt5640: Use the platform data for DMIC settings Oder Chiou
2014-03-28 11:02 ` Mark Brown
2014-03-28 16:05 ` Stephen Warren
2014-03-28 23:46 ` Mark Brown
2014-03-31 15:45 ` Stephen Warren [this message]
2014-03-31 16:05 ` Mark Brown
2014-03-31 16:37 ` Stephen Warren
2014-03-31 17:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53398D7D.3010507@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.