Re: [Buildroot] [PATCH v2 1/1] boot/xilinx-prebuilt: simplify family logic

From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Neal Frager <neal.frager@amd.com>
Cc: buildroot@buildroot.org, ibai.erkiaga-elorza@amd.com,
	luca.ceresoli@bootlin.com, yann.morin@orange.com,
	brandon.maier@collins.com, thomas.petazzoni@bootlin.com,
	romain.naour@smile.fr, michal.simek@amd.com,
	romain.naour@gmail.com
Subject: Re: [Buildroot] [PATCH v2 1/1] boot/xilinx-prebuilt: simplify family logic
Date: Tue, 30 Sep 2025 21:30:24 +0200	[thread overview]
Message-ID: <53398ca895cb5c23aaa8530507340fb4@free.fr> (raw)
In-Reply-To: <20250930125823.971241-1-neal.frager@amd.com>

On 30/09/2025 14:58, Neal Frager via buildroot wrote:
> Currently, the xilinx-prebuilt package uses an if-then-else statement 
> for
> deciding which files need to be installed from the xilinx-prebuilt 
> repo. This
> works fine for now because there are really only two options, either 
> versal or
> zynqmp/kria.
> 
> Starting with the xilinx_v2025.2 release, the versal2 family along with 
> the
> vek385 board will be added to Buildroot and thus the xilinx-prebuilt 
> package
> as well. In the future, additional families will also probably be added 
> to
> this package.
> 
> To avoid creating a long if-then-else-then-else statement which will 
> only grow
> in complexity over time, simplify the logic of the xilinx-prebuilt 
> package by
> giving each xilinx family its own if statement. In the long term, this 
> will
> make the xilinx-prebuilt package easier to understand and maintain.
> 
> For this reason, this patch moves the zynqmp/kria families from the 
> "else"
> statement to having an if statement separate from the versal family.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>

Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot