From mboxrd@z Thu Jan  1 00:00:00 1970
From: sudeep.holla@arm.com (Sudeep Holla)
Date: Mon, 31 Mar 2014 19:25:34 +0100
Subject: [Linaro-acpi] [PATCH v4 1/3] PSCI: Add initial support for
 PSCIv0.2 functions
In-Reply-To: <CAJ5Y-eafEJz487nwg6MRPqL=E3a1gVvWH8yGqYrP+ZqqO-pW9Q@mail.gmail.com>
References: <1396278179-28181-1-git-send-email-ashwin.chaugule@linaro.org>	<1396278179-28181-2-git-send-email-ashwin.chaugule@linaro.org>	<53399D62.5060704@arm.com>	<CAJ5Y-eaC81rqOewzVDEZm=wHbLNWBh32RrLq4nFVa5yHJTT6pQ@mail.gmail.com>
 <CAJ5Y-eafEJz487nwg6MRPqL=E3a1gVvWH8yGqYrP+ZqqO-pW9Q@mail.gmail.com>
Message-ID: <5339B31E.5090406@arm.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Ashwin,

On 31/03/14 18:25, Ashwin Chaugule wrote:
> On 31 March 2014 13:09, Ashwin Chaugule <ashwin.chaugule@linaro.org> wrote:
>> Hi Sudeep,
>>
>> On 31 March 2014 12:52, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>
>>>> +       if (ver == PSCI_RET_EOPNOTSUPP) {
>>>> +               pr_info("PSCI_ID_VERSION Function not supported in firmware.\n");
>>>
>>> IMO you should stop here as the implementation conforming to the specification
>>> must return a minor version number of 2 and major version number of 0. You
>>> can't proceed, assume ids and use them.
>>>
>>
>> hm, you're right, I missed that.
> 
> Something like this?
> 
> if (ver == PSCI_RET_EOPNOTSUPP) {
>          /* PSCI v0.2+ mandates implementation of PSCI_ID_VERSION. */
>          pr_err("PSCI firmware does not comply with the v0.2 spec.\n");
>          err = -EOPNOTSUPP;
>          goto out_put_node;
> 

Yes that looks fine to me.

Regards,
Sudeep