From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-sh@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@lists.codethink.co.uk, magnus.damn@opensource.se,
horms@verge.net.au, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/9] pci-rcar-gen2: add devicetree support
Date: Tue, 01 Apr 2014 01:23:50 +0400 [thread overview]
Message-ID: <5339DCE6.70505@cogentembedded.com> (raw)
In-Reply-To: <53387336.2000306@codethink.co.uk>
Hello.
On 03/30/2014 11:40 PM, Ben Dooks wrote:
>>>>>> Add OF match table for pci-rcar-gen2 driver for device tree support.
>>>> [...]
>>>>>> diff --git a/drivers/pci/host/pci-rcar-gen2.c
>>>>>> b/drivers/pci/host/pci-rcar-gen2.c
>>>>>> index fd3e3ab..1216784 100644
>>>>>> --- a/drivers/pci/host/pci-rcar-gen2.c
>>>>>> +++ b/drivers/pci/host/pci-rcar-gen2.c
>>>>>> @@ -16,6 +16,7 @@
>>>>>> #include <linux/kernel.h>
>>>>>> #include <linux/module.h>
>>>>>> #include <linux/pci.h>
>>>>>> +#include <linux/of_pci.h>
>>>>>> #include <linux/platform_device.h>
>>>>>> #include <linux/pm_runtime.h>
>>>>>> #include <linux/sizes.h>
>>>>> Apologies all, there's a missing include of <linux/of.h> which should
>>>>> have been added here
>>>> Have you ever re-posted this patch fixed? If not, it's not going to
>>>> be merged for 3.15 I guess...
>>> I thought I did.
>> I don't see such repost in 'linux-sh'.
>>> I can have a look a reposting it.
>> It doesn't apply to the current renesas.git devel branch. What tree
>> it was against?
> From my records it was against the -rc3 release of Horms' development
> tree. I know Simon's tree has been closed for the board bits, but I
> could re-send the rcar-pci code.
Could you address my comments and re-send? Or if you don't have time,
would you mind that I take this patch into my hands?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-sh@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@lists.codethink.co.uk, magnus.damn@opensource.se,
horms@verge.net.au, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/9] pci-rcar-gen2: add devicetree support
Date: Mon, 31 Mar 2014 21:23:50 +0000 [thread overview]
Message-ID: <5339DCE6.70505@cogentembedded.com> (raw)
In-Reply-To: <53387336.2000306@codethink.co.uk>
Hello.
On 03/30/2014 11:40 PM, Ben Dooks wrote:
>>>>>> Add OF match table for pci-rcar-gen2 driver for device tree support.
>>>> [...]
>>>>>> diff --git a/drivers/pci/host/pci-rcar-gen2.c
>>>>>> b/drivers/pci/host/pci-rcar-gen2.c
>>>>>> index fd3e3ab..1216784 100644
>>>>>> --- a/drivers/pci/host/pci-rcar-gen2.c
>>>>>> +++ b/drivers/pci/host/pci-rcar-gen2.c
>>>>>> @@ -16,6 +16,7 @@
>>>>>> #include <linux/kernel.h>
>>>>>> #include <linux/module.h>
>>>>>> #include <linux/pci.h>
>>>>>> +#include <linux/of_pci.h>
>>>>>> #include <linux/platform_device.h>
>>>>>> #include <linux/pm_runtime.h>
>>>>>> #include <linux/sizes.h>
>>>>> Apologies all, there's a missing include of <linux/of.h> which should
>>>>> have been added here
>>>> Have you ever re-posted this patch fixed? If not, it's not going to
>>>> be merged for 3.15 I guess...
>>> I thought I did.
>> I don't see such repost in 'linux-sh'.
>>> I can have a look a reposting it.
>> It doesn't apply to the current renesas.git devel branch. What tree
>> it was against?
> From my records it was against the -rc3 release of Horms' development
> tree. I know Simon's tree has been closed for the board bits, but I
> could re-send the rcar-pci code.
Could you address my comments and re-send? Or if you don't have time,
would you mind that I take this patch into my hands?
WBR, Sergei
next prev parent reply other threads:[~2014-03-31 21:23 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 18:01 Renesas RCar device-tree USB series Ben Dooks
2014-03-06 18:01 ` [PATCH 1/9] pci-rcar-gen2: add devicetree support Ben Dooks
2014-03-06 18:01 ` Ben Dooks
2014-03-06 18:01 ` Ben Dooks
2014-03-06 18:21 ` Ben Dooks
2014-03-30 19:10 ` Sergei Shtylyov
2014-03-30 19:10 ` Sergei Shtylyov
2014-03-30 19:10 ` Sergei Shtylyov
2014-03-30 19:21 ` Ben Dooks
2014-03-30 19:21 ` Ben Dooks
2014-03-30 19:26 ` Sergei Shtylyov
2014-03-30 19:26 ` Sergei Shtylyov
2014-03-30 19:40 ` Ben Dooks
2014-03-30 19:40 ` Ben Dooks
2014-03-30 20:10 ` Sergei Shtylyov
2014-03-30 20:10 ` Sergei Shtylyov
2014-03-31 21:23 ` Sergei Shtylyov [this message]
2014-03-31 21:23 ` Sergei Shtylyov
2014-03-30 20:28 ` Sergei Shtylyov
2014-03-30 20:28 ` Sergei Shtylyov
2014-04-04 17:09 ` Bjorn Helgaas
2014-04-04 17:09 ` Bjorn Helgaas
2014-04-04 17:44 ` Ben Dooks
2014-04-04 17:44 ` Ben Dooks
2014-04-04 17:44 ` Ben Dooks
2014-04-04 17:46 ` Sergei Shtylyov
2014-04-04 17:46 ` Sergei Shtylyov
2014-03-06 18:01 ` [PATCH 3/9] phy-rcar-usb-gen2: add device tree support Ben Dooks
2014-03-06 18:01 ` Ben Dooks
2014-03-06 18:16 ` Sergei Shtylyov
2014-03-06 19:16 ` Sergei Shtylyov
2014-03-06 18:19 ` Ben Dooks
2014-03-06 19:54 ` Sergei Shtylyov
2014-03-06 20:54 ` Sergei Shtylyov
2014-03-06 18:01 ` [PATCH 5/9] ARM: shmbobile: r8a7790.dtsi: add pci0/1/2 nodes Ben Dooks
2014-03-06 18:01 ` Ben Dooks
2014-03-31 22:18 ` Sergei Shtylyov
2014-03-31 22:18 ` Sergei Shtylyov
[not found] ` <1394128887-4197-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-03-06 18:01 ` [PATCH 6/9] ARM: shmobile: lager.dts: add pci 0/1/2 Ben Dooks
2014-03-06 18:01 ` Ben Dooks
2014-03-06 18:01 ` [PATCH 7/9] ARM: shmobile: r8a7790.dtsi: add usbphy node Ben Dooks
2014-03-06 18:01 ` Ben Dooks
2014-03-06 18:01 ` [PATCH 8/9] ARM: shmobile: lager.dts: add usbphy reference Ben Dooks
2014-03-06 18:01 ` Ben Dooks
2014-03-30 19:28 ` Sergei Shtylyov
2014-03-30 19:28 ` Sergei Shtylyov
[not found] ` <5338704C.2030501-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-03-30 19:51 ` Ben Dooks
2014-03-30 19:51 ` Ben Dooks
2014-03-07 5:36 ` Renesas RCar device-tree USB series Magnus Damm
2014-03-07 14:30 ` Ben Dooks
2014-03-07 16:30 ` Sergei Shtylyov
2014-03-07 16:32 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5339DCE6.70505@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ben.dooks@codethink.co.uk \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=magnus.damn@opensource.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.