* [PATCH] block-drbd: type is "phy" for drbd backends @ 2014-02-20 15:59 Roger Pau Monne 2014-02-26 15:18 ` Roger Pau Monné 0 siblings, 1 reply; 13+ messages in thread From: Roger Pau Monne @ 2014-02-20 15:59 UTC (permalink / raw) To: drbd-user, xen-devel; +Cc: Roger Pau Monne The type written to xenstore by libxl when attaching a drbd backend is "phy", not "drbd", so handle this case also. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- scripts/block-drbd | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/block-drbd b/scripts/block-drbd index 5563ccb..975802b 100755 --- a/scripts/block-drbd +++ b/scripts/block-drbd @@ -250,7 +250,7 @@ case "$command" in fi case $t in - drbd) + drbd|phy) drbd_resource=$p drbd_role="$(drbdadm role $drbd_resource)" drbd_lrole="${drbd_role%%/*}" @@ -278,7 +278,7 @@ case "$command" in remove) case $t in - drbd) + drbd|phy) p=$(xenstore_read "$XENBUS_PATH/params") drbd_resource=$p drbd_role="$(drbdadm role $drbd_resource)" -- 1.7.7.5 (Apple Git-26) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [Drbd-dev] [PATCH] block-drbd: type is "phy" for drbd backends 2014-02-20 15:59 [PATCH] block-drbd: type is "phy" for drbd backends Roger Pau Monne @ 2014-02-26 15:18 ` Roger Pau Monné 0 siblings, 0 replies; 13+ messages in thread From: Roger Pau Monné @ 2014-02-26 15:18 UTC (permalink / raw) To: drbd-dev; +Cc: xen-devel, drbd-user I've realized I haven't Cc'ed the drbd developers lists, so adding it now. On 20/02/14 16:59, Roger Pau Monne wrote: > The type written to xenstore by libxl when attaching a drbd backend is > "phy", not "drbd", so handle this case also. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > --- > scripts/block-drbd | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/block-drbd b/scripts/block-drbd > index 5563ccb..975802b 100755 > --- a/scripts/block-drbd > +++ b/scripts/block-drbd > @@ -250,7 +250,7 @@ case "$command" in > fi > > case $t in > - drbd) > + drbd|phy) > drbd_resource=$p > drbd_role="$(drbdadm role $drbd_resource)" > drbd_lrole="${drbd_role%%/*}" > @@ -278,7 +278,7 @@ case "$command" in > > remove) > case $t in > - drbd) > + drbd|phy) > p=$(xenstore_read "$XENBUS_PATH/params") > drbd_resource=$p > drbd_role="$(drbdadm role $drbd_resource)" > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] block-drbd: type is "phy" for drbd backends @ 2014-02-26 15:18 ` Roger Pau Monné 0 siblings, 0 replies; 13+ messages in thread From: Roger Pau Monné @ 2014-02-26 15:18 UTC (permalink / raw) To: drbd-dev; +Cc: xen-devel, drbd-user I've realized I haven't Cc'ed the drbd developers lists, so adding it now. On 20/02/14 16:59, Roger Pau Monne wrote: > The type written to xenstore by libxl when attaching a drbd backend is > "phy", not "drbd", so handle this case also. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > --- > scripts/block-drbd | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/block-drbd b/scripts/block-drbd > index 5563ccb..975802b 100755 > --- a/scripts/block-drbd > +++ b/scripts/block-drbd > @@ -250,7 +250,7 @@ case "$command" in > fi > > case $t in > - drbd) > + drbd|phy) > drbd_resource=$p > drbd_role="$(drbdadm role $drbd_resource)" > drbd_lrole="${drbd_role%%/*}" > @@ -278,7 +278,7 @@ case "$command" in > > remove) > case $t in > - drbd) > + drbd|phy) > p=$(xenstore_read "$XENBUS_PATH/params") > drbd_resource=$p > drbd_role="$(drbdadm role $drbd_resource)" > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Drbd-dev] [PATCH] block-drbd: type is "phy" for drbd backends 2014-02-26 15:18 ` Roger Pau Monné (?) @ 2014-02-26 16:30 ` Lars Ellenberg -1 siblings, 0 replies; 13+ messages in thread From: Lars Ellenberg @ 2014-02-26 16:30 UTC (permalink / raw) To: drbd-dev, xen-devel, drbd-user On Wed, Feb 26, 2014 at 04:18:50PM +0100, Roger Pau Monné wrote: > > I've realized I haven't Cc'ed the drbd developers lists, so adding it now. We do read the user's list just as well. Our -dev is actually mainly intended for "coordination". > On 20/02/14 16:59, Roger Pau Monne wrote: > > The type written to xenstore by libxl when attaching a drbd backend is > > "phy", not "drbd", so handle this case also. If you say so; you should know ;-) Did this change at some point? I personally have not used this script in a long while... Do you ("citrix") have this in some regression/integration testing yourself? > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > > --- > > scripts/block-drbd | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/scripts/block-drbd b/scripts/block-drbd > > index 5563ccb..975802b 100755 > > --- a/scripts/block-drbd > > +++ b/scripts/block-drbd > > @@ -250,7 +250,7 @@ case "$command" in > > fi > > > > case $t in > > - drbd) > > + drbd|phy) > > drbd_resource=$p > > drbd_role="$(drbdadm role $drbd_resource)" > > drbd_lrole="${drbd_role%%/*}" > > @@ -278,7 +278,7 @@ case "$command" in > > > > remove) > > case $t in > > - drbd) > > + drbd|phy) > > p=$(xenstore_read "$XENBUS_PATH/params") > > drbd_resource=$p > > drbd_role="$(drbdadm role $drbd_resource)" -- : Lars Ellenberg : LINBIT | Your Way to High Availability : DRBD/HA support and consulting http://www.linbit.com DRBD® and LINBIT® are registered trademarks of LINBIT, Austria. __ please don't Cc me, but send to list -- I'm subscribed ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Drbd-dev] [PATCH] block-drbd: type is "phy" for drbd backends 2014-02-26 15:18 ` Roger Pau Monné (?) (?) @ 2014-02-26 16:30 ` Lars Ellenberg 2014-02-26 17:01 ` [Drbd-dev] " Roger Pau Monné -1 siblings, 1 reply; 13+ messages in thread From: Lars Ellenberg @ 2014-02-26 16:30 UTC (permalink / raw) To: drbd-dev, xen-devel, drbd-user On Wed, Feb 26, 2014 at 04:18:50PM +0100, Roger Pau Monné wrote: > > I've realized I haven't Cc'ed the drbd developers lists, so adding it now. We do read the user's list just as well. Our -dev is actually mainly intended for "coordination". > On 20/02/14 16:59, Roger Pau Monne wrote: > > The type written to xenstore by libxl when attaching a drbd backend is > > "phy", not "drbd", so handle this case also. If you say so; you should know ;-) Did this change at some point? I personally have not used this script in a long while... Do you ("citrix") have this in some regression/integration testing yourself? > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > > --- > > scripts/block-drbd | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/scripts/block-drbd b/scripts/block-drbd > > index 5563ccb..975802b 100755 > > --- a/scripts/block-drbd > > +++ b/scripts/block-drbd > > @@ -250,7 +250,7 @@ case "$command" in > > fi > > > > case $t in > > - drbd) > > + drbd|phy) > > drbd_resource=$p > > drbd_role="$(drbdadm role $drbd_resource)" > > drbd_lrole="${drbd_role%%/*}" > > @@ -278,7 +278,7 @@ case "$command" in > > > > remove) > > case $t in > > - drbd) > > + drbd|phy) > > p=$(xenstore_read "$XENBUS_PATH/params") > > drbd_resource=$p > > drbd_role="$(drbdadm role $drbd_resource)" -- : Lars Ellenberg : LINBIT | Your Way to High Availability : DRBD/HA support and consulting http://www.linbit.com DRBD® and LINBIT® are registered trademarks of LINBIT, Austria. __ please don't Cc me, but send to list -- I'm subscribed ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Drbd-dev] [Xen-devel] [PATCH] block-drbd: type is "phy" for drbd backends 2014-02-26 16:30 ` Lars Ellenberg @ 2014-02-26 17:01 ` Roger Pau Monné 0 siblings, 0 replies; 13+ messages in thread From: Roger Pau Monné @ 2014-02-26 17:01 UTC (permalink / raw) To: drbd-dev, xen-devel, drbd-user On 26/02/14 17:30, Lars Ellenberg wrote: > On Wed, Feb 26, 2014 at 04:18:50PM +0100, Roger Pau Monné wrote: >> >> I've realized I haven't Cc'ed the drbd developers lists, so adding it now. > > We do read the user's list just as well. > Our -dev is actually mainly intended for "coordination". > >> On 20/02/14 16:59, Roger Pau Monne wrote: >>> The type written to xenstore by libxl when attaching a drbd backend is >>> "phy", not "drbd", so handle this case also. > > If you say so; you should know ;-) > Did this change at some point? I'm sure libxl (the new Xen toolstack) uses "phy" and not "drbd" as type. Probably the old xend toolstack was setting type to "drbd", and that's why the script checked for drbd. IMHO, setting the type to phy is the right thing to do, since drbd ends up presenting a block device which is handled by blkback. > I personally have not used this script in a long while... > > Do you ("citrix") have this in some > regression/integration testing yourself? Not in Xen OSS Test suite [0], although I have no idea if other products based on Xen perform any kind of tests with drbd. [0] http://xenbits.xen.org/gitweb/?p=osstest.git;a=summary ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Drbd-dev] [PATCH] block-drbd: type is "phy" for drbd backends @ 2014-02-26 17:01 ` Roger Pau Monné 0 siblings, 0 replies; 13+ messages in thread From: Roger Pau Monné @ 2014-02-26 17:01 UTC (permalink / raw) To: drbd-dev, xen-devel, drbd-user On 26/02/14 17:30, Lars Ellenberg wrote: > On Wed, Feb 26, 2014 at 04:18:50PM +0100, Roger Pau Monné wrote: >> >> I've realized I haven't Cc'ed the drbd developers lists, so adding it now. > > We do read the user's list just as well. > Our -dev is actually mainly intended for "coordination". > >> On 20/02/14 16:59, Roger Pau Monne wrote: >>> The type written to xenstore by libxl when attaching a drbd backend is >>> "phy", not "drbd", so handle this case also. > > If you say so; you should know ;-) > Did this change at some point? I'm sure libxl (the new Xen toolstack) uses "phy" and not "drbd" as type. Probably the old xend toolstack was setting type to "drbd", and that's why the script checked for drbd. IMHO, setting the type to phy is the right thing to do, since drbd ends up presenting a block device which is handled by blkback. > I personally have not used this script in a long while... > > Do you ("citrix") have this in some > regression/integration testing yourself? Not in Xen OSS Test suite [0], although I have no idea if other products based on Xen perform any kind of tests with drbd. [0] http://xenbits.xen.org/gitweb/?p=osstest.git;a=summary ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Drbd-dev] [Xen-devel] [PATCH] block-drbd: type is "phy" for drbd backends 2014-02-26 17:01 ` [Drbd-dev] " Roger Pau Monné @ 2014-04-01 7:12 ` Roger Pau Monné -1 siblings, 0 replies; 13+ messages in thread From: Roger Pau Monné @ 2014-04-01 7:12 UTC (permalink / raw) To: drbd-dev, xen-devel, drbd-user Ping? On 26/02/14 18:01, Roger Pau Monné wrote: > On 26/02/14 17:30, Lars Ellenberg wrote: >> On Wed, Feb 26, 2014 at 04:18:50PM +0100, Roger Pau Monné wrote: >>> >>> I've realized I haven't Cc'ed the drbd developers lists, so adding it now. >> >> We do read the user's list just as well. >> Our -dev is actually mainly intended for "coordination". >> >>> On 20/02/14 16:59, Roger Pau Monne wrote: >>>> The type written to xenstore by libxl when attaching a drbd backend is >>>> "phy", not "drbd", so handle this case also. >> >> If you say so; you should know ;-) >> Did this change at some point? > > I'm sure libxl (the new Xen toolstack) uses "phy" and not "drbd" as > type. Probably the old xend toolstack was setting type to "drbd", and > that's why the script checked for drbd. > > IMHO, setting the type to phy is the right thing to do, since drbd ends > up presenting a block device which is handled by blkback. > >> I personally have not used this script in a long while... >> >> Do you ("citrix") have this in some >> regression/integration testing yourself? > > Not in Xen OSS Test suite [0], although I have no idea if other products > based on Xen perform any kind of tests with drbd. > > [0] http://xenbits.xen.org/gitweb/?p=osstest.git;a=summary > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Drbd-dev] [PATCH] block-drbd: type is "phy" for drbd backends @ 2014-04-01 7:12 ` Roger Pau Monné 0 siblings, 0 replies; 13+ messages in thread From: Roger Pau Monné @ 2014-04-01 7:12 UTC (permalink / raw) To: drbd-dev, xen-devel, drbd-user Ping? On 26/02/14 18:01, Roger Pau Monné wrote: > On 26/02/14 17:30, Lars Ellenberg wrote: >> On Wed, Feb 26, 2014 at 04:18:50PM +0100, Roger Pau Monné wrote: >>> >>> I've realized I haven't Cc'ed the drbd developers lists, so adding it now. >> >> We do read the user's list just as well. >> Our -dev is actually mainly intended for "coordination". >> >>> On 20/02/14 16:59, Roger Pau Monne wrote: >>>> The type written to xenstore by libxl when attaching a drbd backend is >>>> "phy", not "drbd", so handle this case also. >> >> If you say so; you should know ;-) >> Did this change at some point? > > I'm sure libxl (the new Xen toolstack) uses "phy" and not "drbd" as > type. Probably the old xend toolstack was setting type to "drbd", and > that's why the script checked for drbd. > > IMHO, setting the type to phy is the right thing to do, since drbd ends > up presenting a block device which is handled by blkback. > >> I personally have not used this script in a long while... >> >> Do you ("citrix") have this in some >> regression/integration testing yourself? > > Not in Xen OSS Test suite [0], although I have no idea if other products > based on Xen perform any kind of tests with drbd. > > [0] http://xenbits.xen.org/gitweb/?p=osstest.git;a=summary > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Drbd-dev] [PATCH] block-drbd: type is "phy" for drbd backends 2014-04-01 7:12 ` [Drbd-dev] " Roger Pau Monné (?) @ 2014-04-07 14:31 ` Lars Ellenberg -1 siblings, 0 replies; 13+ messages in thread From: Lars Ellenberg @ 2014-04-07 14:31 UTC (permalink / raw) To: drbd-dev, xen-devel, drbd-user On Tue, Apr 01, 2014 at 09:12:21AM +0200, Roger Pau Monné wrote: > Ping? Has been committed to our internal repositories, will find its way to the public git and into the tarballs and packages "soon". > > On 26/02/14 18:01, Roger Pau Monné wrote: > > On 26/02/14 17:30, Lars Ellenberg wrote: > >> On Wed, Feb 26, 2014 at 04:18:50PM +0100, Roger Pau Monné wrote: > >>> > >>> I've realized I haven't Cc'ed the drbd developers lists, so adding it now. > >> > >> We do read the user's list just as well. > >> Our -dev is actually mainly intended for "coordination". > >> > >>> On 20/02/14 16:59, Roger Pau Monne wrote: > >>>> The type written to xenstore by libxl when attaching a drbd backend is > >>>> "phy", not "drbd", so handle this case also. > >> > >> If you say so; you should know ;-) > >> Did this change at some point? > > > > I'm sure libxl (the new Xen toolstack) uses "phy" and not "drbd" as > > type. Probably the old xend toolstack was setting type to "drbd", and > > that's why the script checked for drbd. > > > > IMHO, setting the type to phy is the right thing to do, since drbd ends > > up presenting a block device which is handled by blkback. > > > >> I personally have not used this script in a long while... > >> > >> Do you ("citrix") have this in some > >> regression/integration testing yourself? > > > > Not in Xen OSS Test suite [0], although I have no idea if other products > > based on Xen perform any kind of tests with drbd. > > > > [0] http://xenbits.xen.org/gitweb/?p=osstest.git;a=summary -- : Lars Ellenberg : LINBIT | Your Way to High Availability : DRBD/HA support and consulting http://www.linbit.com DRBD® and LINBIT® are registered trademarks of LINBIT, Austria. __ please don't Cc me, but send to list -- I'm subscribed ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Drbd-dev] [Xen-devel] [PATCH] block-drbd: type is "phy" for drbd backends 2014-04-01 7:12 ` [Drbd-dev] " Roger Pau Monné (?) (?) @ 2014-04-07 14:31 ` Lars Ellenberg 2014-04-07 14:40 ` [Drbd-dev] " Roger Pau Monné 2014-04-07 14:40 ` [Drbd-dev] [Xen-devel] " Roger Pau Monné -1 siblings, 2 replies; 13+ messages in thread From: Lars Ellenberg @ 2014-04-07 14:31 UTC (permalink / raw) To: drbd-dev, xen-devel, drbd-user On Tue, Apr 01, 2014 at 09:12:21AM +0200, Roger Pau Monné wrote: > Ping? Has been committed to our internal repositories, will find its way to the public git and into the tarballs and packages "soon". > > On 26/02/14 18:01, Roger Pau Monné wrote: > > On 26/02/14 17:30, Lars Ellenberg wrote: > >> On Wed, Feb 26, 2014 at 04:18:50PM +0100, Roger Pau Monné wrote: > >>> > >>> I've realized I haven't Cc'ed the drbd developers lists, so adding it now. > >> > >> We do read the user's list just as well. > >> Our -dev is actually mainly intended for "coordination". > >> > >>> On 20/02/14 16:59, Roger Pau Monne wrote: > >>>> The type written to xenstore by libxl when attaching a drbd backend is > >>>> "phy", not "drbd", so handle this case also. > >> > >> If you say so; you should know ;-) > >> Did this change at some point? > > > > I'm sure libxl (the new Xen toolstack) uses "phy" and not "drbd" as > > type. Probably the old xend toolstack was setting type to "drbd", and > > that's why the script checked for drbd. > > > > IMHO, setting the type to phy is the right thing to do, since drbd ends > > up presenting a block device which is handled by blkback. > > > >> I personally have not used this script in a long while... > >> > >> Do you ("citrix") have this in some > >> regression/integration testing yourself? > > > > Not in Xen OSS Test suite [0], although I have no idea if other products > > based on Xen perform any kind of tests with drbd. > > > > [0] http://xenbits.xen.org/gitweb/?p=osstest.git;a=summary -- : Lars Ellenberg : LINBIT | Your Way to High Availability : DRBD/HA support and consulting http://www.linbit.com DRBD® and LINBIT® are registered trademarks of LINBIT, Austria. __ please don't Cc me, but send to list -- I'm subscribed ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Drbd-dev] [PATCH] block-drbd: type is "phy" for drbd backends 2014-04-07 14:31 ` [Drbd-dev] [Xen-devel] " Lars Ellenberg @ 2014-04-07 14:40 ` Roger Pau Monné 2014-04-07 14:40 ` [Drbd-dev] [Xen-devel] " Roger Pau Monné 1 sibling, 0 replies; 13+ messages in thread From: Roger Pau Monné @ 2014-04-07 14:40 UTC (permalink / raw) To: drbd-dev, xen-devel, drbd-user On 07/04/14 16:31, Lars Ellenberg wrote: > On Tue, Apr 01, 2014 at 09:12:21AM +0200, Roger Pau Monné wrote: >> Ping? > > Has been committed to our internal repositories, > will find its way to the public git and > into the tarballs and packages "soon". Thanks, Roger. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Drbd-dev] [Xen-devel] [PATCH] block-drbd: type is "phy" for drbd backends 2014-04-07 14:31 ` [Drbd-dev] [Xen-devel] " Lars Ellenberg 2014-04-07 14:40 ` [Drbd-dev] " Roger Pau Monné @ 2014-04-07 14:40 ` Roger Pau Monné 1 sibling, 0 replies; 13+ messages in thread From: Roger Pau Monné @ 2014-04-07 14:40 UTC (permalink / raw) To: drbd-dev, xen-devel, drbd-user On 07/04/14 16:31, Lars Ellenberg wrote: > On Tue, Apr 01, 2014 at 09:12:21AM +0200, Roger Pau Monné wrote: >> Ping? > > Has been committed to our internal repositories, > will find its way to the public git and > into the tarballs and packages "soon". Thanks, Roger. ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-04-07 14:41 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-02-20 15:59 [PATCH] block-drbd: type is "phy" for drbd backends Roger Pau Monne 2014-02-26 15:18 ` [Drbd-dev] " Roger Pau Monné 2014-02-26 15:18 ` Roger Pau Monné 2014-02-26 16:30 ` [Drbd-dev] " Lars Ellenberg 2014-02-26 16:30 ` Lars Ellenberg 2014-02-26 17:01 ` [Drbd-dev] [Xen-devel] " Roger Pau Monné 2014-02-26 17:01 ` [Drbd-dev] " Roger Pau Monné 2014-04-01 7:12 ` [Drbd-dev] [Xen-devel] " Roger Pau Monné 2014-04-01 7:12 ` [Drbd-dev] " Roger Pau Monné 2014-04-07 14:31 ` Lars Ellenberg 2014-04-07 14:31 ` [Drbd-dev] [Xen-devel] " Lars Ellenberg 2014-04-07 14:40 ` [Drbd-dev] " Roger Pau Monné 2014-04-07 14:40 ` [Drbd-dev] [Xen-devel] " Roger Pau Monné
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.