From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] xen: arm: fully implement multicall interface. Date: Tue, 1 Apr 2014 11:01:26 +0100 Message-ID: <533A8E76.2060006@eu.citrix.com> References: <1396015649-5886-1-git-send-email-ian.campbell@citrix.com> <533585B1.3050608@linaro.org> <1396017452.8670.63.camel@kazak.uk.xensource.com> <53359D5402000078000037B3@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53359D5402000078000037B3@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Ian Campbell Cc: keir@xen.org, tim@xen.org, Julien Grall , xen-devel@lists.xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 03/28/2014 03:03 PM, Jan Beulich wrote: >>>> On 28.03.14 at 15:37, wrote: >> On Fri, 2014-03-28 at 14:22 +0000, Julien Grall wrote: >>> On 03/28/2014 02:07 PM, Ian Campbell wrote: >>>> I'm not sure what I was smoking at the time of 5d74ad1a082e "xen: arm: >>>> implement do_multicall_call for both 32 and 64-bit" but it is obviously >>>> insufficient since it doesn't actually wire up the hypercall. >>>> >>>> Before doing so we need to make the usual adjustments for ARM and turn the >>>> unsigned longs into xen_ulong_t. There is no difference in the resulting >>>> structure for x86. >>>> >>>> There are knock on changes to the trace interface, but again they are nops >> on >>>> x86. >>> >>> I'm wondering if you also need to modify __trace_multicall_call in >>> common/compat/multicall.c. (I know it's not used by ARM...). >> >> I did build test x86_64, but perhaps I should make a change here anyway >> for consistency. George/Jan? > > It doesn't matter that much, but for consistency's sake it would seem > desirable. +1 -G