* [PATCH] kexec: propagate ENOMEM result in error handling
@ 2014-03-29 5:06 Matthew Daley
2014-04-01 10:13 ` David Vrabel
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Daley @ 2014-03-29 5:06 UTC (permalink / raw)
To: xen-devel; +Cc: Matthew Daley, david.vrabel
...otherwise if kimage_alloc_control_page fails (presumably due to
out-of-memory; see the invocation just before this one), the caller of
do_kimage_alloc will think the call was successful.
Signed-off-by: Matthew Daley <mattd@bugfuzz.com>
---
xen/common/kimage.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/common/kimage.c b/xen/common/kimage.c
index 91943f1..9b79a5e 100644
--- a/xen/common/kimage.c
+++ b/xen/common/kimage.c
@@ -182,6 +182,7 @@ static int do_kimage_alloc(struct kexec_image **rimage, paddr_t entry,
goto out;
/* Add an empty indirection page. */
+ result = -ENOMEM;
image->entry_page = kimage_alloc_control_page(image, 0);
if ( !image->entry_page )
goto out;
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kexec: propagate ENOMEM result in error handling
2014-03-29 5:06 [PATCH] kexec: propagate ENOMEM result in error handling Matthew Daley
@ 2014-04-01 10:13 ` David Vrabel
0 siblings, 0 replies; 2+ messages in thread
From: David Vrabel @ 2014-04-01 10:13 UTC (permalink / raw)
To: Matthew Daley; +Cc: xen-devel
On 29/03/14 05:06, Matthew Daley wrote:
> ...otherwise if kimage_alloc_control_page fails (presumably due to
> out-of-memory; see the invocation just before this one), the caller of
> do_kimage_alloc will think the call was successful.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
Thanks.
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-01 10:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-29 5:06 [PATCH] kexec: propagate ENOMEM result in error handling Matthew Daley
2014-04-01 10:13 ` David Vrabel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.