From mboxrd@z Thu Jan 1 00:00:00 1970 From: ben.dooks@codethink.co.uk (Ben Dooks) Date: Tue, 01 Apr 2014 14:19:40 +0100 Subject: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT In-Reply-To: <20140331200620.GA13881@kroah.com> References: <1396284116-19178-1-git-send-email-s.nawrocki@samsung.com> <1396284116-19178-3-git-send-email-s.nawrocki@samsung.com> <20140331200620.GA13881@kroah.com> Message-ID: <533ABCEC.8040701@codethink.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 31/03/14 21:06, Greg KH wrote: > On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: >> This function adds a helper function to configure clock parents and rates >> as specified in clock-parents, clock-rates DT properties for a consumer >> device and a call to it before driver is bound to a device. >> >> Signed-off-by: Sylwester Nawrocki [snip] > > I don't understand why you need the driver core to initialize this one > type of thing? That should be in a driver, or in a class, or at worse > case, the platform code. > > What makes clocks so "unique" here? I suppose the issue here is that a lot of drivers currently use clocks and a number of systems have badly setup default clock trees at start time. Mark Brown and others have argued that the management of clocks which is common to all devices should not live in the driver. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Subject: Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT Date: Tue, 01 Apr 2014 14:19:40 +0100 Message-ID: <533ABCEC.8040701@codethink.co.uk> References: <1396284116-19178-1-git-send-email-s.nawrocki@samsung.com> <1396284116-19178-3-git-send-email-s.nawrocki@samsung.com> <20140331200620.GA13881@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140331200620.GA13881-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg KH , Sylwester Nawrocki Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org List-Id: devicetree@vger.kernel.org On 31/03/14 21:06, Greg KH wrote: > On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: >> This function adds a helper function to configure clock parents and rates >> as specified in clock-parents, clock-rates DT properties for a consumer >> device and a call to it before driver is bound to a device. >> >> Signed-off-by: Sylwester Nawrocki [snip] > > I don't understand why you need the driver core to initialize this one > type of thing? That should be in a driver, or in a class, or at worse > case, the platform code. > > What makes clocks so "unique" here? I suppose the issue here is that a lot of drivers currently use clocks and a number of systems have badly setup default clock trees at start time. Mark Brown and others have argued that the management of clocks which is common to all devices should not live in the driver. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751865AbaDANTq (ORCPT ); Tue, 1 Apr 2014 09:19:46 -0400 Received: from ducie-dc1.codethink.co.uk ([185.25.241.215]:50142 "EHLO ducie-dc1.codethink.co.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751397AbaDANTn (ORCPT ); Tue, 1 Apr 2014 09:19:43 -0400 Message-ID: <533ABCEC.8040701@codethink.co.uk> Date: Tue, 01 Apr 2014 14:19:40 +0100 From: Ben Dooks Organization: Codethink Limited. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.3.0 MIME-Version: 1.0 To: Greg KH , Sylwester Nawrocki CC: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mturquette@linaro.org, linux@arm.linux.org.uk, robh+dt@kernel.org, grant.likely@linaro.org, mark.rutland@arm.com, galak@codeaurora.org, kyungmin.park@samsung.com, sw0312.kim@samsung.com, m.szyprowski@samsung.com, t.figa@samsung.com, laurent.pinchart@ideasonboard.com, s.hauer@pengutronix.de Subject: Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT References: <1396284116-19178-1-git-send-email-s.nawrocki@samsung.com> <1396284116-19178-3-git-send-email-s.nawrocki@samsung.com> <20140331200620.GA13881@kroah.com> In-Reply-To: <20140331200620.GA13881@kroah.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/03/14 21:06, Greg KH wrote: > On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: >> This function adds a helper function to configure clock parents and rates >> as specified in clock-parents, clock-rates DT properties for a consumer >> device and a call to it before driver is bound to a device. >> >> Signed-off-by: Sylwester Nawrocki [snip] > > I don't understand why you need the driver core to initialize this one > type of thing? That should be in a driver, or in a class, or at worse > case, the platform code. > > What makes clocks so "unique" here? I suppose the issue here is that a lot of drivers currently use clocks and a number of systems have badly setup default clock trees at start time. Mark Brown and others have argued that the management of clocks which is common to all devices should not live in the driver. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius